Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-27299] WorkflowJob.disabled #46

Merged
merged 16 commits into from May 12, 2017

Conversation

Projects
None yet
4 participants
@jglick
Copy link
Member

commented May 3, 2017

Unlike #47 this would work on existing baselines. Supersedes #23.

@reviewbybees

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 5, 2017

mvn -f ../jenkins -DskipTests clean install
mvn clean install
mvn -Djenkins.version=2.59-SNAPSHOT surefire:test

passes, meaning that an update of core prior to a plugin update to a version including the planned simplifications will not cause regressions.

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 5, 2017

Build failures are timeouts: INFRA-1176

jglick added a commit to jglick/workflow-job-plugin that referenced this pull request May 5, 2017

jglick added some commits May 5, 2017

@jglick jglick removed the work-in-progress label May 5, 2017

@jglick jglick requested a review from abayer May 5, 2017

@reviewbybees

This comment has been minimized.

Copy link

commented May 5, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick jglick closed this May 9, 2017

@jglick jglick reopened this May 9, 2017

@oleg-nenashev
Copy link
Member

left a comment

LGTM after the quick review 🐝

@abayer

abayer approved these changes May 12, 2017

@jglick jglick closed this May 12, 2017

@jglick jglick reopened this May 12, 2017

@jglick

This comment has been minimized.

Copy link
Member Author

commented May 12, 2017

@jglick jglick closed this May 12, 2017

@jglick jglick reopened this May 12, 2017

@jglick jglick merged commit d1874be into jenkinsci:master May 12, 2017

1 of 2 checks passed

Jenkins Jenkins is validating pull request ...
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@jglick jglick deleted the jglick:WorkflowJob.disabled-JENKINS-27299 branch May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.