Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39134] Deprecate injection #15

Merged
merged 4 commits into from Dec 1, 2016

Conversation

Projects
None yet
3 participants
@jglick
Copy link
Member

commented Nov 30, 2016

Follows up #14 by deprecating the Guice-based Step infrastructure.

Downstream PRs to follow.

@reviewbybees esp. @kohsuke

@reviewbybees

This comment has been minimized.

Copy link

commented Nov 30, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Deleting Javadoc which referred misleadingly to databinding, which is…
… not specific to the Guice-based subclasses.

@jglick jglick referenced this pull request Nov 30, 2016

Merged

Removing uses of Guice #28

@abayer

abayer approved these changes Dec 1, 2016

Copy link
Member

left a comment

🐝

@jglick jglick merged commit 0aeba39 into jenkinsci:master Dec 1, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:guiceless-JENKINS-39134 branch Dec 1, 2016

jglick added a commit that referenced this pull request Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.