Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39134] Deprecate injection #15

merged 4 commits into from Dec 1, 2016
Changes from 1 commit
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now


Deleting Javadoc which referred misleadingly to databinding, which is…

… not specific to the Guice-based subclasses.
  • Loading branch information...
jglick committed Nov 30, 2016
commit fc9a6f407335124f5ab45a2a810c7bbfc1a4eea7
@@ -1,31 +1,14 @@
package org.jenkinsci.plugins.workflow.steps;

import hudson.model.Describable;
import hudson.model.Descriptor;
import jenkins.model.Jenkins;
import net.sf.json.JSONObject;
import org.kohsuke.stapler.DataBoundConstructor;
import org.kohsuke.stapler.DataBoundSetter;
import org.kohsuke.stapler.StaplerRequest;

import javax.annotation.Nullable;
import javax.inject.Inject;

* Partial convenient step implementation.
* <h2>Parameter injection</h2>
* <p>
* {@link Step} implementations are expected to follow the usual GUI-instantiable {@link Describable} pattern.
* {@link AbstractStepImpl} comes with {@linkplain AbstractStepDescriptorImpl a partial implementation of StepDescriptor}
* that automatically instantiate a Step subtype and perform {@link DataBoundConstructor}/{@link DataBoundSetter}
* injections just like {@link Descriptor#newInstance(StaplerRequest, JSONObject)} does from JSON.
* <p>
* In addition, fields and setter methods annotated with {@link StepContextParameter} will get its value
* injected from {@link StepContext}.
* Used with {@link AbstractStepDescriptorImpl} and {@link AbstractStepExecutionImpl}.
* @author Kohsuke Kawaguchi
* @deprecated Directly extend {@link Step} and avoid Guice.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.