Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-37324] Add an ArgumentsColumn to the FlowGraphTable display #39

Merged
merged 2 commits into from Aug 1, 2017

Conversation

@jglick
Copy link
Member

commented Jul 31, 2017

screenshot

See comment in JENKINS-37324. Makes sense to use the new system in the rudimentary built-in UI.

@reviewbybees

@reviewbybees

This comment has been minimized.

Copy link

commented Jul 31, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer
abayer approved these changes Jul 31, 2017
import org.kohsuke.accmod.restrictions.NoExternalUse;
import org.kohsuke.stapler.DataBoundConstructor;

@Restricted(NoExternalUse.class)

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Jul 31, 2017

Member

I am not sure if it makes the descriptor restricted. Likely no

This comment has been minimized.

Copy link
@jglick

jglick Aug 1, 2017

Author Member

If not, I guess that would be considered a bug in the access modifier restrictions library.

@jglick

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2017

@abayer abayer merged commit 6515ef8 into jenkinsci:master Aug 1, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@svanoort

This comment has been minimized.

Copy link
Member

commented Aug 1, 2017

Love it!

@jglick jglick deleted the jglick:ArgumentsColumn-JENKINS-37324 branch Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.