Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option "allow failing build results" #25

Merged
merged 2 commits into from May 16, 2013

Conversation

@timothyekl
Copy link

@timothyekl timothyekl commented May 1, 2013

xcode-plugin already provides the ability to parse the results of running unit tests on an Xcode project by way of configuring a test step. However, since the tests run as a build step, a failing test result will fail the entire build. This may or may not be the desired behavior.

This pull request provides the ability to ignore an error return code from xcodebuild by way of a new option: "Allow failing build results." If checked, xcode-plugin will not treat a non-zero return code from an xcodebuild run as a reason to fail the build step.

This can prove very useful for test build steps configured in tandem with Jenkins' "Publish JUnit test result report" post-build action: if there are failing tests, that action will mark the build unstable, rather than failed. This can help give developers an additional level of information about the status of their build.

* Add a new Boolean option to XCodeBuilder.java
* Add equivalent checkbox in config.jelly
* Document new option in help-allowFailingBuildResults.html

Signed-off-by: Tim Ekl <lithium3141@gmail.com>
@buildhive
Copy link

@buildhive buildhive commented May 1, 2013

Jenkins » xcode-plugin #42 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@timothyekl
Copy link
Author

@timothyekl timothyekl commented May 1, 2013

Looks like maven-hpi-plugin at this URL is now found over here - not sure how to correct that for @buildhive, though.

* Check for null and compare boolean values in XcodeBuilder.java

Signed-off-by: Tim Ekl <lithium3141@gmail.com>
@timothyekl
Copy link
Author

@timothyekl timothyekl commented May 1, 2013

ddcdae6 fixes a NullPointerException on upgrading from xcode-plugin 1.3.1.

@buildhive
Copy link

@buildhive buildhive commented May 1, 2013

Jenkins » xcode-plugin #43 FAILURE
Looks like there's a problem with this pull request
(what's this?)

lacostej added a commit that referenced this issue May 16, 2013
Add new option "allow failing build results"
@lacostej lacostej merged commit a2d1da3 into jenkinsci:master May 16, 2013
@timothyekl timothyekl deleted the allow-failing-builds branch May 31, 2013
@timothyekl timothyekl restored the allow-failing-builds branch May 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants