Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding restoration of the keychains as a build wrapper #31

Merged
merged 2 commits into from Oct 2, 2013

Conversation

@mAu888
Copy link

@mAu888 mAu888 commented May 29, 2013

New approach to keychain restoration. I did not consider aborting a build manually in my first pull request. After a bit of research I found that a BuildWrapper should be the appropriate extension point for restoring the keychains, because it will be run even if the user aborts the build manually.

It may be set in the global configuration which keychains are to be restored. See screenshots attached. The switch for the "Restore keychain" field is because of an annoying bug(?). I had checkboxes first, but when checking just a few keychains to be restored, the ones which are not, won't get saved. See https://groups.google.com/forum/?fromgroups#!topic/jenkinsci-dev/PAf3mFWv1LI

bildschirmfoto 2013-05-29 um 08 54 32

bildschirmfoto 2013-05-29 um 08 54 47

@buildhive
Copy link

@buildhive buildhive commented May 29, 2013

Jenkins » xcode-plugin #63 SUCCESS
This pull request looks good
(what's this?)

@buildhive
Copy link

@buildhive buildhive commented Jun 4, 2013

Jenkins » xcode-plugin #66 SUCCESS
This pull request looks good
(what's this?)

@jenkinsadmin
Copy link
Member

@jenkinsadmin jenkinsadmin commented Sep 22, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@kohsuke
Copy link
Member

@kohsuke kohsuke commented Oct 2, 2013

@mAu888, clearly you've been actively working on this plugin, yet our existing plugin developers are failing to accomodate those changes in a timely fashion.

It'd be great if you can become a committer and push this plugin forward. Let me know if you are OK with my adding you as a committer. This is an important plugin for many, and adding features / fixing issues in a timely fashion is very important.

kohsuke added a commit that referenced this issue Oct 2, 2013
Conflicts:
	src/main/java/au/com/rayh/XCodeBuilder.java
@kohsuke kohsuke merged commit 6cd1152 into jenkinsci:master Oct 2, 2013
@kohsuke
Copy link
Member

@kohsuke kohsuke commented Oct 2, 2013

The pull request disregards people's existing configuration, which is not a good idea.

I've fixed that problem in 497a87a

@mAu888
Copy link
Author

@mAu888 mAu888 commented Oct 15, 2013

@kohsuke Thanks for offering me to be a committer. I'd love to actively help in the development of this plugin. On the other hand I feel my Java knowledge is clearly lacking for this task.

@lacostej
Copy link
Member

@lacostej lacostej commented Oct 15, 2013

Hello, WRT to delays, see the plugin help page in the wiki where I asked for help in a few areas. I now have a few test xcode projects, I just need to take a few hours to set everything up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants