New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the possibility to provide a pattern for the .ipa file name #33

Merged
merged 3 commits into from Oct 2, 2013

Conversation

Projects
None yet
6 participants
@notz

notz commented Jul 5, 2013

Further I extracted the marketing and technical version to its own section. Don't worry, the german localization hasn't been pushed. I'll translate the rest and do a separate pull request.

As suggested I used the EnvVars for the ${BASE_NAME}, ${VERSION}, ${SHORT_VERSION} and ${BUILD_DATE} variables.

This extends this #29 pull request.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive Jul 5, 2013

Jenkins » xcode-plugin #69 SUCCESS
This pull request looks good
(what's this?)

buildhive commented Jul 5, 2013

Jenkins » xcode-plugin #69 SUCCESS
This pull request looks good
(what's this?)

@mAu888

This comment has been minimized.

Show comment
Hide comment
@mAu888

mAu888 Jul 12, 2013

Sweet, thank you. I did not have the time lately to fix this issue.

mAu888 commented Jul 12, 2013

Sweet, thank you. I did not have the time lately to fix this issue.

@jenkinsadmin

This comment has been minimized.

Show comment
Hide comment
@jenkinsadmin

jenkinsadmin Sep 22, 2013

Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Member

jenkinsadmin commented Sep 22, 2013

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

kohsuke added a commit that referenced this pull request Oct 2, 2013

Merge pull request #33 from notz/ipa-name-pattern
Adding the possibility to provide a pattern for the .ipa file name

@kohsuke kohsuke merged commit 3a3628f into jenkinsci:master Oct 2, 2013

@estebanbouza

This comment has been minimized.

Show comment
Hide comment
@estebanbouza

estebanbouza Oct 7, 2013

This feature has broken all my Jobs in Jenkins. When specifying a pattern wasn't supported, the default one was:
${TARGETNAME}-${BUILDTYPE}-${BUILDNUMBER}.ipa
now if you leave the pattern field empty the default one is:
${TARGETNAME}-${BUILDNUMBER}.ipa

Is it possible to change the default pattern in the next release to maintain backwards compatibility?
or at least, is it possible to change the configuration of all the projects via groovy script?

Thanks!

estebanbouza commented Oct 7, 2013

This feature has broken all my Jobs in Jenkins. When specifying a pattern wasn't supported, the default one was:
${TARGETNAME}-${BUILDTYPE}-${BUILDNUMBER}.ipa
now if you leave the pattern field empty the default one is:
${TARGETNAME}-${BUILDNUMBER}.ipa

Is it possible to change the default pattern in the next release to maintain backwards compatibility?
or at least, is it possible to change the configuration of all the projects via groovy script?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment