New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change the Bundle identifier (CFBundleIdentifier) for an xcode build #39

Merged
merged 11 commits into from Apr 20, 2014

Conversation

Projects
None yet
4 participants
@estebanbouza
Copy link

estebanbouza commented Jan 7, 2014

This feature adds the ability to change the bundle ID for a given build.

screen shot 2014-01-07 at 16 51 51

Closes the feature:
https://issues.jenkins-ci.org/browse/JENKINS-13887

@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented Jan 7, 2014

plugins » xcode-plugin #45 SUCCESS
This pull request looks good

@jenkinsadmin

This comment has been minimized.

Copy link
Member

jenkinsadmin commented Jan 7, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@estebanbouza

This comment has been minimized.

Copy link
Author

estebanbouza commented Apr 14, 2014

Ping. Is this project still maintained?

@waltflanagan

This comment has been minimized.

Copy link
Member

waltflanagan commented Apr 14, 2014

Yes, though not as actively as we'd like it to be. I'll take a look at this and try to get it merged this afternoon.

@waltflanagan

This comment has been minimized.

Copy link
Member

waltflanagan commented Apr 14, 2014

I can't merge this as it currently stands.
I get a Null Pointer Exception when trying to run builds that have old configurations where the changeBundleID has not been set.

Recommend you add a null check like #37

@waltflanagan

This comment has been minimized.

Copy link
Member

waltflanagan commented Apr 20, 2014

I'll take care of the null check in a checkin to follow this merge.

waltflanagan added a commit that referenced this pull request Apr 20, 2014

Merge pull request #39 from estebanbouza/master
Ability to change the Bundle identifier (CFBundleIdentifier) for an xcode build

@waltflanagan waltflanagan merged commit f408b7b into jenkinsci:master Apr 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment