Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Suite finish compatibility for Xcode 6 beta 4 #48

Merged
merged 1 commit into from Aug 20, 2014

Conversation

@jonguan
Copy link

@jonguan jonguan commented Aug 1, 2014

[FIXED JENKINS-24120]
Compatible for Xcode 5 and Xcode 6.

Xcode 5 Log:
Test Suite 'SCTests_ResultInterpreter' started at 2014-08-01 04:09:27 +0000
...
Test Suite 'SCTests_ResultInterpreter' finished at 2014-08-01 04:09:27 +0000.
Executed 24 tests, with 0 failures (0 unexpected) in 0.024 (0.025) seconds

Xcode 6 beta 4 log:
Test Suite 'SCTests_ResultInterpreter' started at 2014-07-31 23:23:19 +0000
...
Test Suite 'SCTests_ResultInterpreter' passed at 2014-07-31 23:23:19 +0000.
Executed 24 tests, with 0 failures (0 unexpected) in 0.031 (0.037) seconds

Notice that in Xcode 5, the test log for Test Suite is 'finished', while in Xcode 6, the log states that the suite 'passed'.

@cloudbees-pull-request-builder

plugins » xcode-plugin #57 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

@jenkinsadmin jenkinsadmin commented Aug 2, 2014

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jonguan
Copy link
Author

@jonguan jonguan commented Aug 5, 2014

[FIXED JENKINS-24120]

lacostej added a commit that referenced this issue Aug 20, 2014
Add Test Suite finish compatibility for Xcode 6 beta 4
@lacostej lacostej merged commit 74c8db0 into jenkinsci:master Aug 20, 2014
@cassdeckard
Copy link

@cassdeckard cassdeckard commented Oct 17, 2014

When can we expect to see this in a release of the plugin? I spent the morning troubleshooting this problem before I realized there has been a year's worth of pull request merged into this plugin but no release.

@ewanmellor
Copy link

@ewanmellor ewanmellor commented Oct 31, 2014

I second the request for this to be released! I just spent 3 hours debugging this only to find that it was fixed already. It looks like this plugin hasn't had a release since Dec 2013, but there's lots of good fixes been made since then. Thanks in advance!

@lacostej
Copy link
Member

@lacostej lacostej commented Oct 31, 2014

My bad my bad !! Sorry guys. Hectic times ! I just pushed version 1.4.3 to jenkins-ci.

@ewanmellor
Copy link

@ewanmellor ewanmellor commented Nov 2, 2014

Thanks @lacostej. And thanks for the time that you put into this plugin, it's very much appreciated!

@ncolton
Copy link

@ncolton ncolton commented Nov 25, 2014

Hmm. Is there something that needs to happen for 1.4.3 to be visible / installable through Jenkins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants