Add a field for entering code signing identity #6

Merged
merged 2 commits into from Apr 5, 2012

Conversation

Projects
None yet
9 participants
@katzj

katzj commented Apr 5, 2012

Code signing identities are often something you'd want
to specify differently for an automated build (eg, so your
developers can just have developer certs but jenkins can
set up for distributing builds)

Add a field for entering code signing identity
Code signing identities are often something you'd want
to specify differently for an automated build (eg, so your
developers can just have developer certs but jenkins can
set up for distributing builds)
@@ -389,6 +394,14 @@ public boolean perform(AbstractBuild build, Launcher launcher, BuildListener lis
xcodeReport.append(", configurationBuildDir: DEFAULT");
}
+ // handle code signing identities
+ if (!StringUtils.isEmpty(codeSigningIdentity)) {
+ commandLine.add("CODE_SIGN_IDENTITY=" + codeSigningIdentity);

This comment has been minimized.

Show comment Hide comment
@aheritier

aheritier Apr 5, 2012

Member

Your fix might also help to fix this one : https://issues.jenkins-ci.org/browse/JENKINS-12800
But I'm not sure that it works if you have a space in codeSigningIdentity
Did you try it ?

@aheritier

aheritier Apr 5, 2012

Member

Your fix might also help to fix this one : https://issues.jenkins-ci.org/browse/JENKINS-12800
But I'm not sure that it works if you have a space in codeSigningIdentity
Did you try it ?

This comment has been minimized.

Show comment Hide comment
@katzj

katzj Apr 5, 2012

In fact it does. It's not really the best fix (as there are other options) but that's actually what led me here. I took a few stabs at the regex and decided that this was a quicker path to something working ;-)

@katzj

katzj Apr 5, 2012

In fact it does. It's not really the best fix (as there are other options) but that's actually what led me here. I took a few stabs at the regex and decided that this was a quicker path to something working ;-)

@aheritier

This comment has been minimized.

Show comment Hide comment
@aheritier

aheritier Apr 5, 2012

Member

Can you provide an help file also to document this new configuration field ??

Member

aheritier commented Apr 5, 2012

Can you provide an help file also to document this new configuration field ??

@stephenc

This comment has been minimized.

Show comment Hide comment
@stephenc

stephenc Apr 5, 2012

Member

What would be really cool is if the code signing identity data was stored using the credentials plugin and then transferred to the build slave when needed

Member

stephenc commented Apr 5, 2012

What would be really cool is if the code signing identity data was stored using the credentials plugin and then transferred to the build slave when needed

@katzj

This comment has been minimized.

Show comment Hide comment
@katzj

katzj Apr 5, 2012

@aheritier yep, will add and update the pull request this morning.

@stephenc they have to be pulled from the os/x keychain so I'm not sure of any way to actually export/import in an automated fashion

katzj commented Apr 5, 2012

@aheritier yep, will add and update the pull request this morning.

@stephenc they have to be pulled from the os/x keychain so I'm not sure of any way to actually export/import in an automated fashion

@aheritier

This comment has been minimized.

Show comment Hide comment
@aheritier

aheritier Apr 5, 2012

Member

I forgot the other pull request which I think was to solve the same issue. --sign and CODE_SIGN_IDENTITY have the same behavior no ?
Otherwise you pull-request seems ok, I will test it and merge it

Member

aheritier commented Apr 5, 2012

I forgot the other pull request which I think was to solve the same issue. --sign and CODE_SIGN_IDENTITY have the same behavior no ?
Otherwise you pull-request seems ok, I will test it and merge it

@katzj

This comment has been minimized.

Show comment Hide comment
@katzj

katzj Apr 5, 2012

There is actually a slight difference from my understanding.

CODE_SIGN_IDENTITY has to do with how the .app gets signed. --sign is instead how the packaged .ipa is signed. The two can be different in some cases from what I understand

katzj commented Apr 5, 2012

There is actually a slight difference from my understanding.

CODE_SIGN_IDENTITY has to do with how the .app gets signed. --sign is instead how the packaged .ipa is signed. The two can be different in some cases from what I understand

@aheritier

This comment has been minimized.

Show comment Hide comment
@aheritier

aheritier Apr 5, 2012

Member

ok thus I'll keep the other, I'll have to study it more.

Member

aheritier commented Apr 5, 2012

ok thus I'll keep the other, I'll have to study it more.

aheritier added a commit that referenced this pull request Apr 5, 2012

Merge pull request #6 from katzj/code-sign-identity
Add a field for entering code signing identity

@aheritier aheritier merged commit 6af1b04 into jenkinsci:master Apr 5, 2012

@devguydavid

This comment has been minimized.

Show comment Hide comment
@devguydavid

devguydavid Oct 30, 2012

Any word on when a new release will be made with this feature in place?

Any word on when a new release will be made with this feature in place?

@pyby

This comment has been minimized.

Show comment Hide comment
@pyby

pyby Apr 5, 2013

Any news for a release? I searched this feature on the web

pyby commented Apr 5, 2013

Any news for a release? I searched this feature on the web

@lacostej

This comment has been minimized.

Show comment Hide comment
@lacostej

lacostej Apr 5, 2013

Member

If people want to test the latest build and report.

I am unable to deploy to our prod server right now. We are at the end of
our release cycle.

Should be able in a week or two.

Jerome

On Fri, Apr 5, 2013 at 2:54 PM, Pierre-Yves Bertholon <
notifications@github.com> wrote:

Any news for a release? I searched this feature on the web


Reply to this email directly or view it on GitHubhttps://github.com/jenkinsci/xcode-plugin/pull/6#issuecomment-15953981
.

Jerome Lacoste, +47 40867729, We Want To Know

Member

lacostej commented Apr 5, 2013

If people want to test the latest build and report.

I am unable to deploy to our prod server right now. We are at the end of
our release cycle.

Should be able in a week or two.

Jerome

On Fri, Apr 5, 2013 at 2:54 PM, Pierre-Yves Bertholon <
notifications@github.com> wrote:

Any news for a release? I searched this feature on the web


Reply to this email directly or view it on GitHubhttps://github.com/jenkinsci/xcode-plugin/pull/6#issuecomment-15953981
.

Jerome Lacoste, +47 40867729, We Want To Know

@fwal

This comment has been minimized.

Show comment Hide comment
@fwal

fwal Apr 17, 2013

Any updates? Sadly this is a deal-breaker for me...

fwal commented Apr 17, 2013

Any updates? Sadly this is a deal-breaker for me...

@lacostej

This comment has been minimized.

Show comment Hide comment
@lacostej

lacostej Apr 17, 2013

Member

Have you guys tested the latest build ?

If nobody helps me testing the latest HEAD build on a production server, then you have to wait for me to test it :) As said above, I am in the end of a release cycle and will have time in a few days.

Member

lacostej commented Apr 17, 2013

Have you guys tested the latest build ?

If nobody helps me testing the latest HEAD build on a production server, then you have to wait for me to test it :) As said above, I am in the end of a release cycle and will have time in a few days.

@fwal

This comment has been minimized.

Show comment Hide comment
@fwal

fwal Apr 17, 2013

Cool. :) I'll test it on our server now...

fwal commented Apr 17, 2013

Cool. :) I'll test it on our server now...

@fwal

This comment has been minimized.

Show comment Hide comment
@fwal

fwal Apr 17, 2013

Works perfectly for me!

fwal commented Apr 17, 2013

Works perfectly for me!

@aphex3k

This comment has been minimized.

Show comment Hide comment
@aphex3k

aphex3k Mar 11, 2016

If I change the Code Signing Identity to V38B2WC56E Jenkins fails the build and according to the log /usr/bin/security find-certificate -a -c V38B2WC56E -Z | grep ^SHA-1 comes back empty. But if I log in on the box and run it in the command line I get

buildagent:~ buildagent$ /usr/bin/security find-certificate -a -c V38B2WC56E -Z | grep ^SHA-1
SHA-1 hash: 02F5D4FCD16E7EAD62EF141382F2C05BCD7F28E6

Any ideas?

aphex3k commented Mar 11, 2016

If I change the Code Signing Identity to V38B2WC56E Jenkins fails the build and according to the log /usr/bin/security find-certificate -a -c V38B2WC56E -Z | grep ^SHA-1 comes back empty. But if I log in on the box and run it in the command line I get

buildagent:~ buildagent$ /usr/bin/security find-certificate -a -c V38B2WC56E -Z | grep ^SHA-1
SHA-1 hash: 02F5D4FCD16E7EAD62EF141382F2C05BCD7F28E6

Any ideas?

@gevertex

This comment has been minimized.

Show comment Hide comment
@gevertex

gevertex Nov 10, 2016

Use the name of the signing identity instead ;-)

Use the name of the signing identity instead ;-)

odra added a commit to odra/xcode-plugin that referenced this pull request Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment