Add support for Xcode 7 date format in Unit Testing build task. #63

Merged
merged 2 commits into from Sep 22, 2015

Conversation

Projects
None yet
3 participants
@flabrie

flabrie commented Sep 22, 2015

This is a fix for the JENKINS-30591 issue.

@lacostej

This comment has been minimized.

Show comment Hide comment
@lacostej

lacostej Sep 22, 2015

why do we allow string to be null ?

why do we allow string to be null ?

This comment has been minimized.

Show comment Hide comment
@lacostej

lacostej Sep 22, 2015

maybe use text, instead of string as variable name.

maybe use text, instead of string as variable name.

This comment has been minimized.

Show comment Hide comment
@flabrie

flabrie Sep 22, 2015

Owner

Yes, null are allowed here more by habit, because I use Objective-C a lot more than Java and I usually try to avoid exceptions... This check can be removed of course, and I can rename string to text.

Owner

flabrie replied Sep 22, 2015

Yes, null are allowed here more by habit, because I use Objective-C a lot more than Java and I usually try to avoid exceptions... This check can be removed of course, and I can rename string to text.

@jenkinsadmin

This comment has been minimized.

Show comment Hide comment
@jenkinsadmin

jenkinsadmin Sep 22, 2015

Owner

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Owner

jenkinsadmin commented Sep 22, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Francis Labrie
- Rename variable for more clarity;
-	Don't allow null string to be parsed as date.
@lacostej

This comment has been minimized.

Show comment Hide comment
@lacostej

lacostej Sep 22, 2015

Member

Thanks !

Member

lacostej commented Sep 22, 2015

Thanks !

lacostej added a commit that referenced this pull request Sep 22, 2015

Merge pull request #63 from flabrie/master
Add support for Xcode 7 date format in Unit Testing build task.

@lacostej lacostej merged commit fa1b3f7 into jenkinsci:master Sep 22, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment