Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xcode 7 date format in Unit Testing build task. #63

Merged
merged 2 commits into from Sep 22, 2015

Conversation

@flabrie
Copy link

commented Sep 22, 2015

This is a fix for the JENKINS-30591 issue.

@lacostej

This comment has been minimized.

why do we allow string to be null ?

This comment has been minimized.

Copy link

replied Sep 22, 2015

maybe use text, instead of string as variable name.

This comment has been minimized.

Copy link
Owner

replied Sep 22, 2015

Yes, null are allowed here more by habit, because I use Objective-C a lot more than Java and I usually try to avoid exceptions... This check can be removed of course, and I can rename string to text.

@jenkinsadmin

This comment has been minimized.

Copy link
Member

commented Sep 22, 2015

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Francis Labrie
- Rename variable for more clarity;
-	Don't allow null string to be parsed as date.
@lacostej

This comment has been minimized.

Copy link
Member

commented Sep 22, 2015

Thanks !

lacostej added a commit that referenced this pull request Sep 22, 2015
Merge pull request #63 from flabrie/master
Add support for Xcode 7 date format in Unit Testing build task.

@lacostej lacostej merged commit fa1b3f7 into jenkinsci:master Sep 22, 2015

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.