New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jenkins pipeline support by implementing SimpleBuildStep #74

Merged
merged 2 commits into from May 23, 2017

Conversation

Projects
None yet
6 participants
@jnikolai

jnikolai commented Sep 28, 2016

Hello :)

I added pipeline support for this plugin, and would like to contribute this back to the mainline. It was a fairly straightforward change -- but please let me know if you see any issues with it.

@saiimons

This comment has been minimized.

saiimons commented Oct 19, 2016

Would love to see this in a release soon :)

@raniejade

This comment has been minimized.

raniejade commented Feb 13, 2017

Any updates?

@saiimons

This comment has been minimized.

saiimons commented Feb 13, 2017

@aheritier could maybe give his feedback ;)

@aheritier

LGTM cc @Brantone

@Brantone

This comment has been minimized.

Brantone commented Feb 14, 2017

Sorry, I've been removed from Jenkins + Xcode for a bit.
I don't supposes tests are feasible for these changes?

@raniejade

This comment has been minimized.

raniejade commented Mar 2, 2017

Bumping it up again :)

@Brantone

This comment has been minimized.

Brantone commented Mar 2, 2017

Would still like to see some tests (my availability to focus on Jenkins+Xcode has been limiting, but expect to pick up fairly soon) ; ... however, if everyone's cool with it, I'll try to get it merged + released tonight.

@raniejade

This comment has been minimized.

raniejade commented Apr 4, 2017

Any news?

@aheritier aheritier merged commit c0608aa into jenkinsci:master May 23, 2017

1 check passed

Jenkins This pull request looks good
Details

aheritier added a commit to jenkinsci/pipeline-plugin that referenced this pull request May 24, 2017

@rendion

This comment has been minimized.

rendion commented Mar 13, 2018

This swallows all exception from the perform method when it returns false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment