Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1058 Further fixed for ProofAndSetValue including an .md with testfunctionallity #1172

Conversation

theimo1221
Copy link
Contributor

…nctions to validate ProofAndSetValue functionality

Description

Further fixes of ProofAndSetValue including

  • Proper detection and usage of digits
  • Comparision with min max based on numbers instead of string

Additionally some tests with needed additional functions where added, to allow easier testing/validation of special cases.

Related Issue

#1058

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

Unknown side effects due to now theoretical correct function.

Verification Process

Validation by included testcases.

Release Notes

Further fixes within the validation and formating of number inputs.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

…th testfunctions to validate ProofAndSetValue functionality
@jens-maus jens-maus added 🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component labels Mar 10, 2021
@jens-maus jens-maus added this to the next release milestone Mar 10, 2021
@jens-maus jens-maus merged commit 2424434 into jens-maus:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants