Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key overlapping in russian locale #272

Open
artygrand opened this issue Jan 21, 2018 · 8 comments

Comments

Projects
None yet
8 participants
@mg-code

This comment has been minimized.

Copy link

commented Jan 26, 2018

Not only in Russian. In Latvian as well.

@danhunsaker

This comment has been minimized.

Copy link

commented Jan 26, 2018

This will apply to every locale, since the English name is identical in both short and full forms, and it is English names being used as keys (thanks in part to how PHP works). A proper mechanism to address this is going to require some thought and some adjustment to how the library functions, but is important for every language, not just Russian or Latvian.

See also #253

@GinoPane

This comment has been minimized.

Copy link

commented Apr 4, 2018

@jenssegers Hi! Are you going to look into this?

@RosomahaG

This comment has been minimized.

Copy link

commented May 7, 2018

Here are several another languages that have same problem:

  • de.php
  • et.php
  • fi.php
  • lv.php
  • nl.php
  • ru.php
  • uk.php
  • uz.php
@MaxNozhkin

This comment has been minimized.

Copy link

commented May 7, 2018

+1

@jenssegers

This comment has been minimized.

Copy link
Owner

commented May 7, 2018

Yeah overlooked this issue. But not sure how to work around this.

@artygrand

This comment has been minimized.

Copy link
Author

commented May 7, 2018

Maybe check what name is needed before use?
I made this for myself

@kylekatarnls

This comment has been minimized.

Copy link
Contributor

commented May 13, 2018

I suggest to add a dot to all short keys. Then replace $translated = mb_substr($translated, 0, 3); with $translated = mb_substr($translated, 0, 3).'.';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.