Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve Fish installation instructions #329

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: improve Fish installation instructions #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@ Continue to the next section to install java.
**Untested**: While this fork has improved `fish` shell support, it has not been tested by this maintainer. To install `jenv` for Fish according to the contributor's instructions:

```sh
echo 'set PATH $HOME/.jenv/bin $PATH' >> ~/.config/fish/config.fish
# The line below is not needed if you installed jenv with Homebrew
echo 'fish_add_path $HOME/.jenv/bin' >> ~/.config/fish/config.fish
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, currently by default fish_add_path uses a universal $fish_user_paths variable - stored in the ~/.config/fish/fish_variables file. While fish_add_path checks for duplicates, it might be worth to use the --global flag.


echo 'status --is-interactive; and source (jenv init -|psub)' >> ~/.config/fish/config.fish
cp ~/.jenv/fish/jenv.fish ~/.config/fish/functions/jenv.fish
cp ~/.jenv/fish/export.fish ~/.config/fish/functions/export.fish
ln -sf ~/.jenv/fish/jenv.fish ~/.config/fish/functions/jenv.fish
ln -sf ~/.jenv/fish/export.fish ~/.config/fish/functions/export.fish
```

#### 1.2 Adding Your Java Environment
Expand Down