cleanup #5

Merged
merged 14 commits into from Oct 12, 2012

Conversation

Projects
None yet
3 participants
Contributor

kmike commented Oct 11, 2012

Hello,

I've merged some changes from @palange branch and performed a bit of general cleanup (unicode support fixes, whitespace normalizing, logging cleanup, setup.py script).

Would you like to merge these changes?

Mark Palange and others added some commits May 28, 2012

Mark Palange Support for reading multiple 'Additional Layer Info' blocks.
* Correctly padding ascii name string.
* Refactored 'luni' (Unicode layer name) block parsing for padding.
3f32b9d
Mark Palange Partially parsing the 'TySh' type tool layer.
Reading up to the Text data descriptor which appears to use the
pdf format. Go figure.
c38a18c
Mark Palange Added parsing for the 'warp' data of the text layer 383d6c3
Mark Palange Storing text_layer data with layer.
Fixed text layer parsing bug.
a821c39
Mark Palange Storing text layer transform fields 6a8263f
Mark Palange Merge pull request #1 from palange/feat/text_info
Parsing of text_layer data
Reviewed by @teng, @palange
4904cdc
Mark Palange Ignoring .pyc files 838551d
Mark Palange Changes to allow exporting of PSD files with masks.
The exporter won't crash - but it also will not merge the
mask into the layer image.

* Fixed a signed/unsigned bug when loading mask bbox.
* Skipping the mask channel(s) when constructing layer image
f540fb0
Mark Palange Fixed indetation issue 8b767be
@kmike kmike unneeded imports are removed 916f6f9
@kmike kmike whitespaces are normalized 05ba5db
@kmike kmike non-global logger d731752
@kmike kmike unicode fixes d092e7d
@kmike kmike packaging 3094fd8

@jerem jerem added a commit that referenced this pull request Oct 12, 2012

@jerem jerem Merge pull request #5 from kmike/master
cleanup
35307c5

@jerem jerem merged commit 35307c5 into jerem:master Oct 12, 2012

Contributor

palange commented on 3094fd8 Oct 12, 2012

This commit broke my tool that was using psdparse. :(

Contributor

kmike replied Oct 12, 2012

I'm sorry; it was probably better to extract "Let's get started!" functiona s "def main():" and leave it in psdparser.py (and reuse it in a script).

Contributor

palange replied Oct 15, 2012

Its okay - It points out a deficiency in the way I build and deploy my tool. I was using psdparsers as a git submodule so its code was deployed in my tool's file structure. I should instead set up a virtualenv to deploy my tool scripts dependencies. The packaging you provided will help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment