Skip to content

Jeremy Kemper jeremy

Organizations

Ruby on Rails Basecamp Official Rack repositories
April 20, 2014
jeremy commented on pull request rails/rails#14001
Jeremy Kemper

@dmitry Complete, effective tests are a prerequisite for code review. You'll find that incomplete pull requests simply do not get attention. This i…

April 17, 2014
jeremy commented on pull request rails/rails#14738
Jeremy Kemper

Looks good. Needs a rebase against latest master, then good to merge.

April 17, 2014
jeremy closed issue mikel/mail#700
Jeremy Kemper
Iterating over header and deleting fields unpredictable
April 17, 2014
jeremy commented on issue mikel/mail#700
Jeremy Kemper

Deleting from the collection you're iterating over doesn't work in general: >> a=[1,2,3,4,5,6]; a.each { |i| a.delete_if { |j| j == i }}; a => [2, 4,

April 17, 2014
jeremy closed issue mikel/mail#699
Jeremy Kemper
From with non-plain From
April 17, 2014
jeremy commented on issue mikel/mail#699
Jeremy Kemper

Neither address parses since they're missing the <...> around the address: >> mail = Mail.new('From: "Pavel Ryska [XXX s.r.o.]" pavel.ryska@XXX.cz') …

April 17, 2014
jeremy commented on pull request rails/rails#11516
Jeremy Kemper

Whether a string is fixed-length or variable-length is a characteristic of the string, so introducing a new type feels off. #3402's approach makes …

April 15, 2014
jeremy commented on pull request rails/rails#13345
Jeremy Kemper

@TechFounder Sounds like you're making a GET request that has a JavaScript response, but you aren't passing the X-Requested-With request header. Yo…

April 14, 2014
jeremy commented on issue basecamp/bcx-api#101
Jeremy Kemper

@meisanerd Probably because it's a missing feature, rather than a broken feature. It's on our list, in any case!

April 14, 2014
jeremy commented on pull request rails/rails#14738
Jeremy Kemper

No need to concat the method tag onto an empty string. This is sufficient: method_tag

April 14, 2014
jeremy commented on pull request rails/rails#14738
Jeremy Kemper

utf8_enforcer_tag + method_tag

April 14, 2014
jeremy commented on pull request rails/rails#14738
Jeremy Kemper

I called out Firefox 12 as an example, but it wasn't the only one, so staking a case on its 0.21% is flimsy. Clearer to say that we're dropping HTM…

April 14, 2014
jeremy commented on pull request rails/rails#14738
Jeremy Kemper

Omit.

April 14, 2014
jeremy commented on pull request rails/rails#14282
Jeremy Kemper

I hear you, but the fact that we're calling a convenience writer method instead of #replace doesn't change the situation. It does, for sure, introd…

April 14, 2014
jeremy commented on issue rails/rails#14734
Jeremy Kemper

We used to to_s to compare PK & FK. There was no test, but it is a regression. We could check corresponding column types and only to_s if they don'…

April 14, 2014
jeremy closed pull request rails/rails#14282
Jeremy Kemper
Update CollectionAssociation.ids_writer to update changed_attributes
April 14, 2014
jeremy commented on pull request rails/rails#14282
Jeremy Kemper

This is surprising. I assumed this would be dirty-tracking foreign keys that would be nullified by the #replace call. Dirty tracking is limited to …

April 14, 2014
jeremy commented on pull request rails/rails#14282
Jeremy Kemper

#id is always the pk (load_target.map(&:id)) but not necessarily the FK we need. Can use ids_reader here which uses #association_foreign_key.

April 14, 2014
jeremy commented on pull request rails/rails#11123
April 14, 2014
jeremy closed issue rails/rails#13460
Jeremy Kemper
Stop swallowing exceptions from`after_commit` callbacks
April 14, 2014
jeremy commented on issue rails/rails#13460
April 14, 2014
jeremy commented on issue mikel/mail#696
Jeremy Kemper

Thanks @kswope !

April 13, 2014
jeremy commented on pull request rails/rails#11407
Jeremy Kemper

Here's what led to a div with these idiosyncratic inline styles: is not a valid child of by HTML 4.01 Strict and XHTML Strict. Hence the wrapper. O…

April 12, 2014
jeremy commented on pull request rails/rails#14717
Jeremy Kemper

:heart:

April 11, 2014
jeremy commented on commit rails/rails@e533855383
Jeremy Kemper

[*Array.wrap(*binds)].flatten.presence.blank?.to_s.inquiry.true? Can't be too sure :shipit:

April 11, 2014
jeremy commented on issue basecamp/bcx-api#53
Jeremy Kemper

Added fullsize_avatar_url :grin:

jeremy deleted branch fullsize-avatar-url at basecamp/bcx-api
April 11, 2014
April 11, 2014
Jeremy Kemper
April 11, 2014
jeremy merged pull request basecamp/bcx-api#124
Jeremy Kemper
Include full-size avatar URLs
1 commit with 63 additions and 29 deletions
April 11, 2014
jeremy commented on pull request mikel/mail#681
Jeremy Kemper

Scoping it to this file seems fine since it's a separate core extension.

Something went wrong with that request. Please try again.