Jeremy Daer (Kemper) jeremy

Organizations

@rails @basecamp @rack
jeremy commented on commit rails/actioncable@d014bf9328
@jeremy

Perhaps this should be up to the user to choose: epoll = Linux only; may want BSD kqueue or the select default.

jeremy commented on issue basecamp/powprox#3
@jeremy

Hi @dgdosen – you're welcome! Thanks for giving it a shot. Could you verify that your homebrew nginx config ends with a toplevel include servers/*;

jeremy commented on pull request rails/rails#21110
@jeremy

:+1: nice @kamipo !

jeremy commented on pull request rails/rails#20574
@jeremy

Using ERB within yaml to set metadata feels surprising. How about using a special key to set fixture metadata? _fixture: model_class: User david: n…

@jeremy
  • @jeremy 01d4262
    HTML responses get UTF-8 charset by default
jeremy commented on pull request rails/rails#21057
@jeremy

@tenderlove stubbed some toes on the same thing—ring a bell?

jeremy commented on pull request rails/rails#21057
@jeremy

Could flip to keep_if to simplify the expression a bit.

jeremy commented on pull request rails/rails#21057
@jeremy

Red flag, kind of thing that may cause subtle/untested regressions.

jeremy commented on pull request rails/rails#21057
@jeremy

Changes a presence check to a nil check—can this value legitimately be nil?

jeremy commented on pull request rails/rails#21057
@jeremy

Could switch to a parameterized_parts.delete_if { … ?

jeremy commented on pull request rails/rails#21057
@jeremy

Is value ever nil?

jeremy commented on pull request rails/rails#21057
@jeremy

Combining control flow (next as early-return) and a boolean expression feels a little awkward. How about folding the not-nil check into the express…

jeremy commented on pull request rails/rails#21057
@jeremy

Nice work @schneems !

@jeremy
jeremy merged pull request basecamp/powprox#2
@jeremy
Support homebrewed pow installation
1 commit with 5 additions and 1 deletion
jeremy commented on pull request basecamp/powprox#2
@jeremy

Thanks @krasnoukhov!

jeremy commented on pull request basecamp/powprox#2
@jeremy

How about flipping this conditional? Check for a mainline Pow install first, then fall back to just relying on $PATH: pow_bin="$HOME/Library/Applic…

jeremy commented on pull request rails/rails#20986
@jeremy

:+1:

@jeremy
  • @jeremy 86d1064
    text/html is gzipped by default, so we can omit it from gzip_types
jeremy commented on pull request rack/rack-contrib#111
@jeremy

:+1:

jeremy commented on pull request rails/rails#20923
@jeremy

We should match shipped behavior at this point. I was thinking the idea for render body: '…' was to not set the Content-Type at all, though?

jeremy commented on pull request rails/rails#20923
@jeremy

Ah right, due to the respond_to blocks. Maybe using html: is clearer, then.

jeremy commented on pull request rails/rails#20923
@jeremy

Did switching from text: to body: change the default content type?

jeremy commented on pull request rails/rails#20923
@jeremy

Should be html: ?

jeremy commented on pull request rails/rails#20923
@jeremy

Good case for using body:

jeremy commented on pull request rails/rails#20923
@jeremy

Would avoid using the body: option in docs. Makes sense to use plain: if we're rendering text.

jeremy pushed to master at rails/rails
@jeremy
jeremy merged pull request rails/rails#20917
@jeremy
Add deprecation warning for `render :text`
1 commit with 56 additions and 11 deletions
@jeremy
@jeremy
  • @jeremy 83ec15e
    Setup is the default subcommand. Prefer to just run powprox.