Jeremy Kemper jeremy

Organizations

Ruby on Rails Basecamp Official Rack repositories
jeremy pushed to master at rails/rails
Jeremy Kemper
  • Jeremy Kemper 7142059
    Revert integration test refactoring that caused app test regressions
jeremy pushed to master at rails/rails
Jeremy Kemper
  • Jeremy Kemper a13e52b
    Revert "Merge pull request #18764 from tsun1215/master"
jeremy commented on pull request rails/rails#18764
Jeremy Kemper

Reverting this so master can move forward with passing tests. Please do revisit!

jeremy pushed to master at mikel/mail
Jeremy Kemper
jeremy merged pull request mikel/mail#782
Jeremy Kemper
Use composition over inheritance for `PartsList`
3 commits with 64 additions and 10 deletions
jeremy created tag v3.2.5 at basecamp/trashed
Jeremy Kemper
  • Jeremy Kemper d0e3ada
    3.2.5: support Ruby 2.2 GC.stat naming
Jeremy Kemper
  • Jeremy Kemper 1458db1
    Fix default headers in test responses
Jeremy Kemper
  • Jeremy Kemper a63760c
    Fix default headers in test responses
jeremy commented on pull request rails/rails#18423
Jeremy Kemper

Fixed by optionally merging the default headers rather than disabling the merge. Added a regression test for functional tests to demonstrate (thanks

jeremy pushed to master at rails/rails
Jeremy Kemper
  • Jeremy Kemper f6e293e
    Fix default headers in test responses
jeremy commented on pull request rails/rails#18948
Jeremy Kemper

:ship: On Tuesday, February 24, 2015, Kasper Timm Hansen notifications@github.com wrote: Sure thing, [image: :+1:]. I'm pretty excited too :) — Reply to t…

jeremy commented on pull request rails/rails#18423
Jeremy Kemper

This assumes that a TestResponse is always instantiated with an existing response's headers, which include the default headers. Is that accurate? I…

jeremy pushed to master at rails/rails
Jeremy Kemper
  • Jeremy Kemper f4f9408
    Add a failing test demonstrating regression with HEAD requests to Rac…
jeremy commented on pull request rails/rails#18764
Jeremy Kemper

Hmm, I don't think we can fix both situations. We'd need to change get from "match GET" to "match GET & HEAD" instead of doing two passes, one matc…

jeremy commented on pull request rails/rails#18764
Jeremy Kemper

Looks like this means HEAD requests to mounted Rack apps will no longer work. We're missing a test case for that, so it slipped through the cracks!

jeremy pushed to master at rails/rails
Jeremy Kemper
  • Jeremy Kemper 26915a1
    Fix c479480638508c20601af69ca46b5b606c2d5b4d to account for from_valu…
Jeremy Kemper
  • Jeremy Kemper 98c27ba
    Tighten rest-client dep to 1.6.8+ since 1.6.7- have the Tempfile.binm…
Jeremy Kemper
  • Jeremy Kemper 444332b
    Relax rest-client and webmock deps to allow newer versions. Update te…
jeremy commented on pull request rails/rails#18948
Jeremy Kemper

Do we have a test demonstrating that the leading <# … %> is acceptable?

jeremy commented on pull request rails/rails#18937
Jeremy Kemper

Nice work @simi. Pardon the repeated remarks, looks like I missed concurrent feedback too. Thanks!

jeremy commented on pull request rails/rails#18937
Jeremy Kemper

Since this is in the Railtie, it'll surprisingly affect apps that upgrade to newer Rails. We'll need to generate new apps with it set, but use false

jeremy commented on pull request rails/rails#18937
Jeremy Kemper

If we still support required: true, we should still test it.

jeremy commented on pull request rails/rails#18937
Jeremy Kemper

Out of context, I wouldn't know what this "require belongs to" means. Is there a clearer config name?

jeremy commented on pull request rails/rails#18937
Jeremy Kemper

I think it'll be odd to switch to optional: on belongs_to but keep required: for has_one.

jeremy commented on pull request rails/rails#18937
Jeremy Kemper

I'm finding the control flow here a little difficult to follow. Consider condensing the conditionals and using the :optional option to determine wh…

jeremy commented on pull request rails/rails#18956
Jeremy Kemper

:tada: Congrats @hjoo !

jeremy commented on pull request rails/rails#18936
Jeremy Kemper

@arthurnn That could be a rewarding direction, but relying on current_transaction within callbacks is awkward, and ultimately it takes us back to t…

jeremy commented on pull request rails/rails#18936
Jeremy Kemper

before_committed! would match the existing committed! & rolledback!

jeremy commented on pull request rails/rails#18936
Jeremy Kemper

Ditto re. :after_*