Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop/crash when multiple Tweenable instances call .tween multiple times #111

Closed
jeremyckahn opened this Issue Mar 5, 2019 · 6 comments

Comments

Projects
None yet
1 participant
@jeremyckahn
Copy link
Owner

jeremyckahn commented Mar 5, 2019

I'm still investigating this and haven't figured out all the details, but this issue was discovered here.

I'm opening this issue to track progress on a fix.

/cc 4ian/GDevelop#922

@jeremyckahn

This comment has been minimized.

Copy link
Owner Author

jeremyckahn commented Mar 6, 2019

I figured out a consistent reproduction of the bug: https://codepen.io/jeremyckahn/pen/RdoeJb

Apologies about this! I am working out a fix ASAP (though I don't have a time estimate). In the meantime falling back to 2.4.0 seems to be the best stable workaround.

@jeremyckahn jeremyckahn referenced this issue Mar 6, 2019

Closed

[WIP] Tween extension #922

18 of 21 tasks complete
@jeremyckahn

This comment has been minimized.

Copy link
Owner Author

jeremyckahn commented Mar 6, 2019

I'm feeling a bit better with the solution I've got in the works. The linked list removal wasn't cleaning up some references it needed to.

I'll have to come back to this and make sure everything is bullet-proof once I have time again in the next few days.

@jeremyckahn

This comment has been minimized.

Copy link
Owner Author

jeremyckahn commented Mar 6, 2019

For now I've published 2.7.2-0 to unblock anyone affected by this issue. I feel that it should be in good shape but I want to make sure to properly review and test these changes before making a full patch release.

@jeremyckahn

This comment has been minimized.

Copy link
Owner Author

jeremyckahn commented Mar 7, 2019

As commented elsewhere I found some issues with this fix and am working on getting it more stable before releasing it. The infinite loop/crashing issues seem to be resolved, though.

@jeremyckahn

This comment has been minimized.

Copy link
Owner Author

jeremyckahn commented Mar 7, 2019

Made some progress in 2.7.2-1. Still needs more testing, but this is looking better.

jeremyckahn added a commit that referenced this issue Mar 9, 2019

@jeremyckahn

This comment has been minimized.

Copy link
Owner Author

jeremyckahn commented Mar 9, 2019

2.7.2 has been published, which fixes this issue. I'll add a bit of unit testing around the linked list implementation this weekend for good measure, but this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.