promised fix for pagedSearch and few other problems I noticed #11

Merged
merged 4 commits into from Dec 6, 2011

Conversation

Projects
None yet
2 participants
@huancz

huancz commented Dec 6, 2011

No description provided.

Petr Běhan added some commits Dec 6, 2011

Petr Běhan
bugfix: wrong interpretation of ldap_result return value
didn't cause problems because LDAP.js ignores 'disconnected' event now
Petr Běhan
fix suspicious use of ldap file descriptors
One problem: when openldap library handles reconnect and succeeds, there
is no guarantee that the file descriptor will stay the same - but binding
didn't detect this.

Second problem: calling ev_io_set on c->read_watcher_ that may be active is
explicitly forbidden in libev docs.

jeremycx added a commit that referenced this pull request Dec 6, 2011

Merge pull request #11 from huancz/master
promised fix for pagedSearch and few other problems I noticed

@jeremycx jeremycx merged commit 99d0dfb into jeremycx:master Dec 6, 2011

@jeremycx

This comment has been minimized.

Show comment Hide comment
@jeremycx

jeremycx Dec 6, 2011

Owner

Awesome, thanks!

Owner

jeremycx commented Dec 6, 2011

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment