New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional support for wildcard routes #20

Closed
jeremydaly opened this Issue Mar 28, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@jeremydaly
Copy link
Owner

jeremydaly commented Mar 28, 2018

Wildcard routes are useful mostly for OPTIONS calls, which are necessary for preflight CORS checks. If you are splitting your app into multiple functions, being able to wildcard just certain paths would be very useful.

@jeremydaly jeremydaly added this to the v0.5 milestone Apr 6, 2018

@jeremydaly

This comment has been minimized.

Copy link
Owner

jeremydaly commented Apr 24, 2018

I've experimented with a few ways to do this. Initially I added the wildcard detection to the path traversal method, meaning a wildcard path would match any unmatched path. This screwed up some tests because now there were no more not found errors. I've decided to implement wildcards after path discovery. Basically this means that a path has to be defined using at least one method in order for a wildcard route to match it on another method. I think this makes more sense given the general use case being for CORS.

@jeremydaly

This comment has been minimized.

Copy link
Owner

jeremydaly commented Apr 24, 2018

Implemented in v0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment