Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

includes: clean up system headers

Ran IWYU audits for missing or unnecessary system includes on Linux
and FreeBSD, cleaned up based on the results.

git-svn-id: https://aqualung.svn.sourceforge.net/svnroot/aqualung/trunk@1245 3cd24cdc-1f22-0410-b8b1-dcf80e670293
  • Loading branch information...
commit e49bcec5d1271f39494a13a7b4d813632bd68202 1 parent 4d22e52
Jamie Heilman authored
Showing with 62 additions and 55 deletions.
  1. +1 −0  src/about.c
  2. +0 −2  src/build_store.c
  3. +1 −0  src/cd_ripper.c
  4. +1 −0  src/cdda.c
  5. +2 −1  src/core.c
  6. +2 −0  src/cover.c
  7. +2 −0  src/decoder/dec_cdda.c
  8. +1 −0  src/decoder/dec_flac.c
  9. +2 −1  src/decoder/dec_lavc.c
  10. +2 −0  src/decoder/dec_mac.cpp
  11. +3 −1 src/decoder/dec_mod.c
  12. +0 −4 src/decoder/dec_mod.h
  13. +3 −1 src/decoder/dec_mpc.c
  14. +2 −1  src/decoder/dec_mpc.h
  15. +2 −0  src/decoder/dec_mpeg.c
  16. +2 −1  src/decoder/dec_mpeg.h
  17. +1 −0  src/decoder/dec_speex.c
  18. +1 −0  src/decoder/dec_speex.h
  19. +1 −0  src/decoder/dec_vorbis.c
  20. +1 −0  src/decoder/dec_vorbis.h
  21. +2 −1  src/decoder/dec_wavpack.c
  22. +1 −6 src/decoder/file_decoder.c
  23. +2 −0  src/decoder/file_decoder.h
  24. +0 −1  src/encoder/enc_flac.c
  25. +0 −2  src/encoder/enc_flac.h
  26. +1 −0  src/encoder/enc_lame.c
  27. +0 −1  src/encoder/enc_sndfile.c
  28. +0 −2  src/encoder/enc_vorbis.c
  29. +0 −1  src/encoder/file_encoder.c
  30. +1 −1  src/export.c
  31. +0 −2  src/file_info.c
  32. +1 −2  src/gui_main.c
  33. +4 −1 src/httpc.c
  34. +1 −1  src/i18n.h
  35. +1 −2  src/ifp_device.c
  36. +1 −0  src/loop_bar.c
  37. +1 −0  src/metadata.c
  38. +0 −1  src/metadata_ape.c
  39. +1 −0  src/metadata_ape.h
  40. +0 −1  src/metadata_flac.c
  41. +0 −2  src/metadata_id3v1.c
  42. +0 −1  src/metadata_id3v2.c
  43. +3 −0  src/metadata_id3v2.h
  44. +0 −1  src/metadata_ogg.c
  45. +1 −1  src/metadata_ogg.h
  46. +0 −3  src/music_browser.c
  47. +2 −1  src/playlist.c
  48. +1 −0  src/plugin.c
  49. +0 −1  src/podcast.c
  50. +0 −3  src/ports.c
  51. +2 −1  src/rb.h
  52. +0 −1  src/search.c
  53. +0 −1  src/search_playlist.c
  54. +1 −0  src/segv.c
  55. +0 −1  src/store_cdda.c
  56. +3 −1 src/transceiver.c
  57. +1 −0  src/utils_gui.c
  58. +1 −0  src/volume.c
View
1  src/about.c
@@ -20,6 +20,7 @@
#include <config.h>
+#include <stdio.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
2  src/build_store.c
@@ -26,7 +26,6 @@
#include <stdlib.h>
#include <time.h>
#include <string.h>
-#include <unistd.h>
#include <fnmatch.h>
#include <regex.h>
#include <glib.h>
@@ -36,7 +35,6 @@
#include <gtk/gtk.h>
#include <libxml/parser.h>
#include <libxml/tree.h>
-#include <sys/stat.h>
#ifdef HAVE_CDDB
#include "cddb_lookup.h"
View
1  src/cd_ripper.c
@@ -23,6 +23,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <unistd.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
1  src/cdda.c
@@ -23,6 +23,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <time.h>
#include <unistd.h>
#include <glib.h>
#include <gdk-pixbuf/gdk-pixbuf.h>
View
3  src/core.c
@@ -20,14 +20,15 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <unistd.h>
#include <fcntl.h>
+#include <locale.h>
#include <math.h>
-#include <time.h>
#include <getopt.h>
#include <time.h>
#include <sys/time.h>
View
2  src/cover.c
@@ -24,7 +24,9 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include <dirent.h>
+#include <limits.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
2  src/decoder/dec_cdda.c
@@ -20,9 +20,11 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <sys/types.h>
#include <time.h>
#undef HAVE_CDDB
View
1  src/decoder/dec_flac.c
@@ -20,6 +20,7 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
View
3  src/decoder/dec_lavc.c
@@ -20,9 +20,10 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
-#include <string.h>
+#include <sys/types.h>
#include <ctype.h>
#include <libavutil/avutil.h>
View
2  src/decoder/dec_mac.cpp
@@ -20,8 +20,10 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
+#include <string.h>
/* expand this to nothing so there's no error when including MACLib.h */
View
4 src/decoder/dec_mod.c
@@ -20,13 +20,15 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include <ctype.h>
#include <limits.h>
#include <unistd.h>
-#include <sys/types.h>
+#include <sys/mman.h>
#include <sys/stat.h>
#include <fcntl.h>
View
4 src/decoder/dec_mod.h
@@ -21,10 +21,6 @@
#ifndef AQUALUNG_DEC_MOD_H
#define AQUALUNG_DEC_MOD_H
-#include <sys/mman.h>
-#ifdef __FreeBSD__
-#include <sys/types.h>
-#endif /* __FreeBSD__ */
#include <sys/stat.h>
#include <libmodplug/modplug.h>
View
4 src/decoder/dec_mpc.c
@@ -20,9 +20,11 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
-#include <unistd.h>
+#include <string.h>
+#include <math.h>
#include "../i18n.h"
#include "../metadata.h"
View
3  src/decoder/dec_mpc.h
@@ -21,11 +21,12 @@
#ifndef AQUALUNG_DEC_MPC_H
#define AQUALUNG_DEC_MPC_H
+#include <stdio.h>
+
#ifdef MPC_OLD_API
#include <mpcdec/mpcdec.h>
#else
#include <mpc/mpcdec.h>
-#include <math.h>
#endif /* MPC_OLD_API */
#include "../rb.h"
View
2  src/decoder/dec_mpeg.c
@@ -20,9 +20,11 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
+#include <sys/mman.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
View
3  src/decoder/dec_mpeg.h
@@ -21,7 +21,8 @@
#ifndef AQUALUNG_DEC_MPEG_H
#define AQUALUNG_DEC_MPEG_H
-#include <sys/mman.h>
+#include <stdio.h>
+#include <sys/stat.h>
#include <mad.h>
#include "../common.h"
View
1  src/decoder/dec_speex.c
@@ -21,6 +21,7 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
View
1  src/decoder/dec_speex.h
@@ -21,6 +21,7 @@
#ifndef AQUALUNG_DEC_SPEEX_H
#define AQUALUNG_DEC_SPEEX_H
+#include <stdio.h>
#include <oggz/oggz.h>
#include <speex/speex.h>
View
1  src/decoder/dec_vorbis.c
@@ -20,6 +20,7 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
View
1  src/decoder/dec_vorbis.h
@@ -21,6 +21,7 @@
#ifndef AQUALUNG_DEC_VORBIS_H
#define AQUALUNG_DEC_VORBIS_H
+#include <stdio.h>
#include <vorbis/codec.h>
#ifdef _WIN32
#undef _WIN32
View
3  src/decoder/dec_wavpack.c
@@ -20,10 +20,11 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
-
#include <string.h>
+#include <sys/types.h>
#include <math.h>
#include "../metadata.h"
View
7 src/decoder/file_decoder.c
@@ -23,12 +23,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <errno.h>
-#include <unistd.h>
-#include <fcntl.h>
-#include <math.h>
-#include <time.h>
-#include <sys/stat.h>
+#include <strings.h>
#include "../httpc.h"
#include "../metadata.h"
View
2  src/decoder/file_decoder.h
@@ -21,6 +21,8 @@
#ifndef AQUALUNG_FILE_DECODER_H
#define AQUALUNG_FILE_DECODER_H
+#include <math.h>
+
#include "../common.h"
#include "../metadata.h"
View
1  src/encoder/enc_flac.c
@@ -26,7 +26,6 @@
#include <stdio.h>
#include <stdlib.h>
-#include <string.h>
#include <FLAC/format.h>
#include <FLAC/metadata.h>
View
2  src/encoder/enc_flac.h
@@ -21,8 +21,6 @@
#ifndef AQUALUNG_ENC_FLAC_H
#define AQUALUNG_ENC_FLAC_H
-#include <stdio.h>
-
#ifdef HAVE_FLAC_ENC
#include <FLAC/ordinals.h>
#include <FLAC/stream_encoder.h>
View
1  src/encoder/enc_lame.c
@@ -20,6 +20,7 @@
#include <config.h>
+#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
View
1  src/encoder/enc_sndfile.c
@@ -22,7 +22,6 @@
#include <stdio.h>
#include <stdlib.h>
-#include <string.h>
#include "enc_sndfile.h"
View
2  src/encoder/enc_vorbis.c
@@ -26,9 +26,7 @@
#include <stdio.h>
#include <stdlib.h>
-#include <string.h>
#include <time.h>
-#include <math.h>
#include <vorbis/vorbisenc.h>
#include "../common.h"
View
1  src/encoder/file_encoder.c
@@ -22,7 +22,6 @@
#include <stdio.h>
#include <stdlib.h>
-#include <string.h>
#include "enc_flac.h"
#include "enc_lame.h"
View
2  src/export.c
@@ -20,6 +20,7 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
@@ -27,7 +28,6 @@
#include <errno.h>
#include <fnmatch.h>
#include <sys/stat.h>
-#include <sys/types.h>
#include <glib.h>
#include <glib/gstdio.h>
#include <glib-object.h>
View
2  src/file_info.c
@@ -24,8 +24,6 @@
#include <stdlib.h>
#include <string.h>
#include <ctype.h>
-#include <assert.h>
-#include <sys/stat.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
3  src/gui_main.c
@@ -23,11 +23,10 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <ctype.h>
#include <unistd.h>
-#include <math.h>
#include <sys/stat.h>
#include <errno.h>
+#include <time.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
5 src/httpc.c
@@ -20,15 +20,18 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include <errno.h>
#include <unistd.h>
#include <fcntl.h>
#include <sys/types.h>
+#include <sys/select.h>
#include <sys/socket.h>
-#include <sys/wait.h>
+#include <sys/time.h>
#include <netinet/in.h>
#include <netdb.h>
View
2  src/i18n.h
@@ -2,7 +2,7 @@
#define AQUALUNG_I18N_H
#include "gettext.h"
-#include <locale.h>
+
#define _(Text) gettext(Text)
#define N_(Text) gettext_noop(Text)
View
3  src/ifp_device.c
@@ -22,8 +22,8 @@
#include <config.h>
#include <stdio.h>
-#include <stdlib.h>
#include <string.h>
+#include <unistd.h>
#include <sys/stat.h>
#include <glib.h>
#include <glib/gstdio.h>
@@ -31,7 +31,6 @@
#include <gdk/gdk.h>
#include <gdk/gdkkeysyms.h>
#include <gtk/gtk.h>
-#include <limits.h>
#include <usb.h>
#include <ifp.h>
View
1  src/loop_bar.c
@@ -20,6 +20,7 @@
#include <config.h>
+#include <stddef.h>
#include <glib.h>
#include <gdk/gdk.h>
#include <gtk/gtk.h>
View
1  src/metadata.c
@@ -23,6 +23,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include "common.h"
#include "i18n.h"
View
1  src/metadata_ape.c
@@ -24,7 +24,6 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
-#include <ctype.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk-pixbuf/gdk-pixbuf.h>
View
1  src/metadata_ape.h
@@ -21,6 +21,7 @@
#ifndef AQUALUNG_METADATA_APE_H
#define AQUALUNG_METADATA_APE_H
+#include <sys/types.h>
#include <glib.h>
#include "decoder/file_decoder.h"
View
1  src/metadata_flac.c
@@ -23,7 +23,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <unistd.h>
#include <ctype.h>
#include <glib.h>
#include <FLAC/metadata.h>
View
2  src/metadata_id3v1.c
@@ -21,10 +21,8 @@
#include <config.h>
#include <stdio.h>
-#include <stdlib.h>
#include <string.h>
#include <unistd.h>
-#include <ctype.h>
#include <glib.h>
#include "utils.h"
View
1  src/metadata_id3v2.c
@@ -24,7 +24,6 @@
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
-#include <ctype.h>
#include <glib.h>
#include "common.h"
View
3  src/metadata_id3v2.h
@@ -21,6 +21,9 @@
#ifndef AQUALUNG_METADATA_ID3V2_H
#define AQUALUNG_METADATA_ID3V2_H
+#include <stdio.h>
+#include <sys/types.h>
+
#include "metadata.h"
View
1  src/metadata_ogg.c
@@ -23,7 +23,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <unistd.h>
#include <ctype.h>
#include <glib.h>
View
2  src/metadata_ogg.h
@@ -23,8 +23,8 @@
#include <config.h>
+#include <sys/types.h>
#include <glib.h>
-
#ifdef HAVE_VORBIS
#include <vorbis/codec.h>
#endif /* HAVE_VORBIS */
View
3  src/music_browser.c
@@ -22,9 +22,6 @@
#include <stdio.h>
#include <string.h>
-#include <stdlib.h>
-#include <unistd.h>
-#include <sys/stat.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
3  src/playlist.c
@@ -20,12 +20,13 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
+#include <stdlib.h>
#include <string.h>
#include <dirent.h>
#include <unistd.h>
#include <sys/stat.h>
-#include <math.h>
#include <glib.h>
#include <glib/gstdio.h>
#include <glib-object.h>
View
1  src/plugin.c
@@ -22,6 +22,7 @@
#include <stdio.h>
#include <stdlib.h>
+#include <string.h>
#include <dlfcn.h>
#include <unistd.h>
#include <dirent.h>
View
1  src/podcast.c
@@ -20,7 +20,6 @@
#include <config.h>
-#include <fcntl.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
View
3  src/ports.c
@@ -20,12 +20,9 @@
#include <config.h>
-#include <errno.h>
-#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <unistd.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
View
3  src/rb.h
@@ -22,7 +22,8 @@
#ifndef AQUALUNG_RB_H
#define AQUALUNG_RB_H
-#include <sys/types.h>
+#include <stddef.h>
+
#ifdef __cplusplus
extern "C" {
View
1  src/search.c
@@ -21,7 +21,6 @@
#include <config.h>
#include <stdio.h>
-#include <stdlib.h>
#include <string.h>
#include <glib.h>
#include <glib-object.h>
View
1  src/search_playlist.c
@@ -21,7 +21,6 @@
#include <config.h>
#include <stdio.h>
-#include <stdlib.h>
#include <string.h>
#include <glib.h>
#include <glib-object.h>
View
1  src/segv.c
@@ -9,6 +9,7 @@
#include <config.h>
+#include <stddef.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
View
1  src/store_cdda.c
@@ -23,7 +23,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
-#include <unistd.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdkkeysyms.h>
View
4 src/transceiver.c
@@ -24,10 +24,12 @@
#include <stddef.h>
#include <string.h>
#include <errno.h>
-#include <stdlib.h>
#include <unistd.h>
+#include <sys/select.h>
#include <sys/socket.h>
+#include <sys/time.h>
#include <sys/un.h>
+#include <time.h>
#include <glib.h>
#include "common.h"
View
1  src/utils_gui.c
@@ -21,6 +21,7 @@
#include <config.h>
#include <ctype.h>
+#include <stdio.h>
#include <stdlib.h>
#include <stdarg.h>
#include <string.h>
View
1  src/volume.c
@@ -24,6 +24,7 @@
#include <stdlib.h>
#include <string.h>
#include <math.h>
+#include <time.h>
#include <glib.h>
#include <glib-object.h>
#include <gdk/gdk.h>
Please sign in to comment.
Something went wrong with that request. Please try again.