Permalink
Browse files

Removing specific quote_identifiers default - let Sequel handle things

  • Loading branch information...
1 parent 19ba7c9 commit 6fdcd9b31492fda384820ef46a06e1cfa9667f8e @wishdev wishdev committed Jan 25, 2009
Showing with 2 additions and 11 deletions.
  1. +0 −9 lib/sequel_core/adapters/firebird.rb
  2. +2 −2 spec/adapters/firebird_spec.rb
@@ -212,10 +212,6 @@ def transaction(server=nil)
def disconnect_connection(c)
c.close
end
-
- def quote_identifiers_default
- false
- end
end
# Dataset class for Firebird datasets
@@ -285,11 +281,6 @@ def literal(v)
end
end
- def quote_identifier(name)
- name = super
- Fb::Global::reserved_keyword?(name) ? quoted_identifier(name.upcase) : name
- end
-
# The order of clauses in the SELECT SQL statement
def select_clause_order
SELECT_CLAUSE_ORDER
@@ -205,9 +205,9 @@ def FIREBIRD_DB.ret_commit
specify "should quote and upcase reserved keywords" do
@d = FIREBIRD_DB[:testing]
- @d.upcase_identifiers= false
+ @d.quote_identifiers = true
@d.select(:select).sql.should == \
- 'SELECT "SELECT" FROM testing'
+ 'SELECT "SELECT" FROM "TESTING"'
end
end

0 comments on commit 6fdcd9b

Please sign in to comment.