Add TypeConvertor jdbc/sqlserver DateTimeOffset #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DateTimeOffset should be returned as a ruby Time instead of the raw jdbc type.
|
Thanks for the patch. This looks good to me. I'm going to need to make a few changes, because this breaks on older versions of the SQL Server JDBC driver, and the spec breaks when using jdbc/jtds. But I should be able to fix those issues fairly easily. |
|
The spec actually breaks on many different adapters (odbc, ado, older versions of tiny_tds), in different ways on each. I'll have to do some more testing tomorrow and see if the issues can be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeOffset should be returned as a ruby Time instead of the raw jdbc type.