ADO access adapter implement tables, foreign_key_list, views using OpenSchema #546

Merged
merged 4 commits into from Sep 6, 2012

Conversation

Projects
None yet
2 participants
@ericgj
Contributor

ericgj commented Sep 6, 2012

It was all surprisingly not that difficult. See what you think.

@jeremyevans

This comment has been minimized.

Show comment
Hide comment
@jeremyevans

jeremyevans Sep 6, 2012

Owner

This looks good. I'll do some testing tomorrow and merge it. Thanks!

Owner

jeremyevans commented Sep 6, 2012

This looks good. I'll do some testing tomorrow and merge it. Thanks!

@jeremyevans jeremyevans merged commit a970b03 into jeremyevans:master Sep 6, 2012

@jeremyevans

This comment has been minimized.

Show comment
Hide comment
@jeremyevans

jeremyevans Sep 6, 2012

Owner

No problems in my basic testing. I also committed a spec change and now I can run the specs on Access without them all failing (though >50% still fail). This should make it much easier to improve Sequel's support on Access, just by looking at the spec failures and fixing them if possible.

Owner

jeremyevans commented Sep 6, 2012

No problems in my basic testing. I also committed a spec change and now I can run the specs on Access without them all failing (though >50% still fail). This should make it much easier to improve Sequel's support on Access, just by looking at the spec failures and fixing them if possible.

@ericgj

This comment has been minimized.

Show comment
Hide comment
@ericgj

ericgj Sep 6, 2012

Contributor

Great. Yeah, I noticed that too running the specs. I think a lot may have to do with the 'table is locked' problem (e.g. create_table! raises this consistently). But I want to look closer at it soon.

BTW I just released a gem for a database transfer tool I put together (which was some motivation for putting these changes in). I'd love your feedback if you have a minute to look at it sometime.

Contributor

ericgj commented Sep 6, 2012

Great. Yeah, I noticed that too running the specs. I think a lot may have to do with the 'table is locked' problem (e.g. create_table! raises this consistently). But I want to look closer at it soon.

BTW I just released a gem for a database transfer tool I put together (which was some motivation for putting these changes in). I'd love your feedback if you have a minute to look at it sometime.

@jeremyevans

This comment has been minimized.

Show comment
Hide comment
@jeremyevans

jeremyevans Sep 6, 2012

Owner

wineskins looks cool. It's basically similar to bin/sequel -C or taps, but with the ability to have more control instead of just doing a straight copy.

One change I would recommend is not creating indexes until after the inserts, since it's slower to create index and then insert than it is to insert then create index.

Owner

jeremyevans commented Sep 6, 2012

wineskins looks cool. It's basically similar to bin/sequel -C or taps, but with the ability to have more control instead of just doing a straight copy.

One change I would recommend is not creating indexes until after the inserts, since it's slower to create index and then insert than it is to insert then create index.

@ericgj

This comment has been minimized.

Show comment
Hide comment
@ericgj

ericgj Sep 6, 2012

Contributor

thx, I hadn't noticed sequel -C or taps. and thanks for the suggestion re indexes.

Contributor

ericgj commented Sep 6, 2012

thx, I hadn't noticed sequel -C or taps. and thanks for the suggestion re indexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment