Adding documentation for qualified database name query #589

Merged
merged 1 commit into from Nov 29, 2012

Projects

None yet

2 participants

@dcampano

This was the area of the documentation that I was looking for the answer. Not sure if you want to include this update or want me to change anything. Thanks!

@jeremyevans
Owner

First, thank you taking the time to submit a patch.

The problem with this addition is that this new documentation is not accurate for most databases that Sequel supports, it's only accurate for MySQL, since MySQL treats separate databases similar to schemas in SQL. This addition is wrong on PostgreSQL, where you can't do cross-database queries (without a foreign data wrapper), and I think it's also wrong on Microsoft SQL Server (where you need an additional level of qualification, since it supports both cross schema and cross database queries).

I do think qualified tables should be mentioned more prominently, and the place you picked seems like a good place to do so, so I'll merge this and tweak the language and example to be more general.

@dcampano

Sounds good, thanks for letting me know the issues.

BTW, thanks for an awesome library! Just started using in the last couple
days and really enjoy it!

On Thu, Nov 29, 2012 at 4:28 PM, Jeremy Evans notifications@github.comwrote:

First, thank you taking the time to submit a patch.

The problem with this addition is that this new documentation is not
accurate for most databases that Sequel supports, it's only accurate for
MySQL, since MySQL treats separate databases similar to schemas in SQL.
This addition is wrong on PostgreSQL, where you can't do cross-database
queries (without a foreign data wrapper), and I think it's also wrong on
Microsoft SQL Server (where you need an additional level of qualification,
since it supports both cross schema and cross database queries).

I do think qualified tables should be mentioned more prominently, and the
place you picked seems like a good place to do so, so I'll merge this and
tweak the language and example to be more general.


Reply to this email directly or view it on GitHubhttps://github.com/jeremyevans/sequel/pull/589#issuecomment-10867225.

@jeremyevans jeremyevans merged commit 8e62130 into jeremyevans:master Nov 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment