update JDBC driver loading to handle latest jdbc gems #598

Merged
merged 1 commit into from Jan 7, 2013

Conversation

Projects
None yet
2 participants
Contributor

kares commented Dec 27, 2012

latest gems no longer auto-load the driver jar but instead provide a load_driver method, this change is handled backward compatible (since not all driver gems are updated + users might decide to stick with an older gem version).

also maybe HSQLDB might get updated since there's now a 2.2.9 gem ... http://git.io/73rxYA
https://github.com/jruby/activerecord-jdbc-adapter/tree/jdbc-hsqldb-2.2.9/jdbc-hsqldb/lib

@kares kares update JDBC driver loading to handle latest jdbc gems
latest gems no longer auto-load the driver jar but instead provide a load_driver method, this change is handled backward compatible (since not all driver gems are updated + users might decide to stick with an older gem version).
55140b4

kares referenced this pull request in jruby/activerecord-jdbc-adapter Dec 27, 2012

Closed

5.1.22 version breaks sequel integration #280

Owner

jeremyevans commented Dec 27, 2012

This looks good. I'll test it when I get back from vacation.

Using the jdbc-hsqldb gem is fine now that they upgraded the version. I can probably test that as well when I get back.

@jeremyevans jeremyevans merged commit 55140b4 into jeremyevans:master Jan 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment