Update README to clarify how to install gem with support for databases with more than 256 columns #14

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
@bornio
Contributor

bornio commented Aug 8, 2013

No description provided.

@jeremyevans

This comment has been minimized.

Show comment Hide comment
@jeremyevans

jeremyevans Aug 8, 2013

Owner

Two issues with this:

  1. It needs to be rebased against master.
  2. The README explanation should be changed so that mentions result sets with over 256 columns. The current wording with "databases" is not accurate.

Once those changes are made I can merge this. Thanks!

Owner

jeremyevans commented Aug 8, 2013

Two issues with this:

  1. It needs to be rebased against master.
  2. The README explanation should be changed so that mentions result sets with over 256 columns. The current wording with "databases" is not accurate.

Once those changes are made I can merge this. Thanks!

@bornio bornio closed this Aug 9, 2013

@bornio bornio reopened this Aug 9, 2013

@bornio

This comment has been minimized.

Show comment Hide comment
@bornio

bornio Aug 9, 2013

Contributor

I recall there was a way to cancel a pull request...
Anyway, should be fine now I think?

Contributor

bornio commented Aug 9, 2013

I recall there was a way to cancel a pull request...
Anyway, should be fine now I think?

@jeremyevans

This comment has been minimized.

Show comment Hide comment
@jeremyevans

jeremyevans Aug 9, 2013

Owner

This doesn't appear to be rebased against master. Also, the README text mentions table instead of result set. It works fine with a table with 256 columns, as long as you don't select more than 256 columns. Also, you can still run into issues with tables less than 256 columns, by selecting expressions or joining tables. I'll just cherry-pick the necessary commit and modify it. Thanks.

Owner

jeremyevans commented Aug 9, 2013

This doesn't appear to be rebased against master. Also, the README text mentions table instead of result set. It works fine with a table with 256 columns, as long as you don't select more than 256 columns. Also, you can still run into issues with tables less than 256 columns, by selecting expressions or joining tables. I'll just cherry-pick the necessary commit and modify it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment