Fixed debug.pass_methods getting squashed regardless of log level #4

Merged
merged 1 commit into from Apr 11, 2012

Conversation

Projects
None yet
2 participants
Contributor

mleglise commented Apr 10, 2012

debug.clear, debug.group, and all other "pass_methods" are currently getting removed from the compiled files, even when they should be left alone.

This patch fixes it and adds tests for debug.group and debug.groupEnd

Extra credit for adding tests, merging in.

jeremygpeterson added a commit that referenced this pull request Apr 11, 2012

Merge pull request #4 from mleglise/fix_debug_pass_methods
Fixed debug.pass_methods getting squashed regardless of log level

@jeremygpeterson jeremygpeterson merged commit 3da634d into jeremygpeterson:master Apr 11, 2012

Owner

jeremygpeterson commented Apr 11, 2012

Marc,

Thanks for the pull requests, these are merged in and now available on
version 0.3.2.

Sincerely,

Jeremy

On , Marc Leglise
reply@reply.github.com
wrote:

debug.clear, debug.group, and all other "pass_methods" are currently
getting removed from the compiled files, even when they should be left
alone.

This patch fixes it and adds tests for debug.group and debug.groupEnd

You can merge this Pull Request by running:

git pull https://github.com/mleglise/jsdebug-rails fix_debug_pass_methods

Or you can view, comment on it, or merge it online at:

#4

-- Commit Summary --

  • Fixed debug.pass_methods getting squashed regardless of log level

-- File Changes --

M lib/jsdebug/processor.rb (10)

A test/fixtures/assets/pass_debugs.js (4)

M test/test_debug_processor.rb (10)

-- Patch Links --

https://github.com/jeremygpeterson/jsdebug-rails/pull/4.patch

https://github.com/jeremygpeterson/jsdebug-rails/pull/4.diff


Reply to this email directly or view it on GitHub:

#4

Contributor

mleglise commented Apr 11, 2012

Thanks for the fast turn-around Jeremy! This gem solves the JS logging problem rather elegantly, so I'm happy to help.

Owner

jeremygpeterson commented Apr 12, 2012

The pipeline really simplifies the problem, though it still feels weird to
trust the way it serves assets. Testing javascript files still bugs me,
but I'm hoping asset delivery will mature more.

Thanks for the feedback, and enjoy,

Jeremy

On Wed, Apr 11, 2012 at 12:18 PM, Marc Leglise <
reply@reply.github.com

wrote:

Thanks for the fast turn-around Jeremy! This gem solves the JS logging
problem rather elegantly, so I'm happy to help.


Reply to this email directly or view it on GitHub:

#4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment