Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust nightly changes #249

Closed
gkoz opened this issue Mar 26, 2015 · 4 comments
Closed

Rust nightly changes #249

gkoz opened this issue Mar 26, 2015 · 4 comments

Comments

@gkoz
Copy link
Contributor

gkoz commented Mar 26, 2015

The trivial casts lint is upon us. Whoever starts fixing the warnings can leave a message here.
@gkoz
Copy link
Contributor Author

gkoz commented Mar 27, 2015

It seems the trivial_numeric_casts lint may become allow by default.
rust-lang/rfcs#1020

@GuillaumeGomez
Copy link
Contributor

Oh come on ! They're can't be serious ! It was a pain in the pass to update some of my libs yesterday and they say I did it for nothing ? Seriously... Well, luckily, I didn't start doing it on rgtk...

@gkoz
Copy link
Contributor Author

gkoz commented Mar 27, 2015

What's worse, in cases of i64 as c_long (which can be i32 or i64 on different platforms) and vice versa, removing the cast would be incorrect.

@GuillaumeGomez
Copy link
Contributor

For that, I totally agree. But I was thinking that they somehow found a way to cast automatically if this is a c_type to waiting type. Seemed logical to me...

@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 1, 2015
Closed
@gkoz gkoz closed this as completed Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuillaumeGomez @gkoz