Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving reproducible build #5026

Closed
nhumblot opened this issue Nov 5, 2022 · 1 comment · Fixed by #5079
Closed

Improving reproducible build #5026

nhumblot opened this issue Nov 5, 2022 · 1 comment · Fixed by #5079
Assignees

Comments

@nhumblot
Copy link
Collaborator

nhumblot commented Nov 5, 2022

Is your feature request related to a problem? Please describe.
@hboutemy is working on reproducible builds and encounter issues with DependencyCheck on this topic.

https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/owasp/dependency-check/README.md

Describe the solution you'd like
The script should end in success when testing for reproducible builds for future versions.

Describe alternatives you've considered

No alternative has been considered

Additional context

His PR #4302 improved the situation, but is not enough. His script still detects diffs.

Wen talking together, he identified a small typo in the PR, which needs to be fixed among other issues: https://github.com/jeremylong/DependencyCheck/pull/4302/files#r1014648841

Other issues needs to be investigated by executing the script available in the reproducible-central repository.

Commits total count and tags in generated git.properties should be removed. We will need to upgrade the maven-plugin-plugin too.

@nhumblot nhumblot self-assigned this Nov 5, 2022
hboutemy added a commit to hboutemy/DependencyCheck that referenced this issue Nov 21, 2022
@hboutemy
Copy link
Contributor

@nhumblot #5079 provided

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants