New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disable ruby analyzer? #992

Closed
pioto opened this Issue Nov 16, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@pioto

pioto commented Nov 16, 2017

Please delete any un-needed section from the following issue template:

Reporting Bugs/Errors

https://gist.github.com/pioto/39ba1cb830a0cbed952a50aed48641a6

It seems that, if the ruby bundle-audit tool is not present, then this tool will always fail the Maven build. I've even attempted to outright disable this integration, using <rubygemsAnalyzerEnabled>false</rubygemsAnalyzerEnabled>, but it still tries to run it.

I have no ruby in my code base, so this analyzer is irrelevant.

@jeremylong jeremylong added the question label Nov 18, 2017

@jeremylong

This comment has been minimized.

Show comment
Hide comment
@jeremylong

jeremylong Nov 18, 2017

Owner

I think we need to update the documentation a little. What you need to disable is the bundleAuditAnalyzerEnabled:

<configuration>
   <bundleAuditAnalyzerEnabled>false</bundleAuditAnalyzerEnabled>
</comfiguration>

There are actually two analyzers for Ruby and they work differently.

Owner

jeremylong commented Nov 18, 2017

I think we need to update the documentation a little. What you need to disable is the bundleAuditAnalyzerEnabled:

<configuration>
   <bundleAuditAnalyzerEnabled>false</bundleAuditAnalyzerEnabled>
</comfiguration>

There are actually two analyzers for Ruby and they work differently.

@pioto

This comment has been minimized.

Show comment
Hide comment
@pioto

pioto Nov 21, 2017

I'll try that, but I'd argue that the tool should still fail gracefully in the absence of this other tool, and just log a warning that it couldn't run that analysis and move on.

pioto commented Nov 21, 2017

I'll try that, but I'd argue that the tool should still fail gracefully in the absence of this other tool, and just log a warning that it couldn't run that analysis and move on.

@jeremylong

This comment has been minimized.

Show comment
Hide comment
@jeremylong

jeremylong Nov 21, 2017

Owner

I'd argue that dependency-check should fail under this condition - with clearer instructions on how to disable the offending analyzer.

Owner

jeremylong commented Nov 21, 2017

I'd argue that dependency-check should fail under this condition - with clearer instructions on how to disable the offending analyzer.

@jeremylong jeremylong closed this Feb 25, 2018

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot Sep 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot commented Sep 27, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.