Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Definition of _push #28

Closed
dabbertorres opened this issue Apr 6, 2014 · 4 comments
Closed

Multiple Definition of _push #28

dabbertorres opened this issue Apr 6, 2014 · 4 comments

Comments

@dabbertorres
Copy link
Contributor

g++ 4.8.1 throws a "multiple definition" error for the _push functions in primitives.h (starting at line 205).
Making all of them inline seems to fix this.

It also throws it for _lua_dispatcher at line 15 in BaseFun.h
Making it inline fixes it as well.

@jeremyong
Copy link
Owner

Hmm strange that this doesn't show up in the test cases although it doesn't surprise me that they need to be inlined. Thanks for making the issue.

@jeremyong
Copy link
Owner

Could you try the code in fix-28 (https://github.com/jeremyong/Selene/tree/fix-28) and let me know if that fixes things for you?

Also, do the test case pass for you in 4.8.1?

@dabbertorres
Copy link
Contributor Author

Yes, it seems to have fixed it.

And yes, the test cases pass. For both master and fix-28.

@jeremyong
Copy link
Owner

Fixed in e61e835

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants