some UI improvements and minor fixes #3

Merged
merged 37 commits into from Jul 22, 2013

Conversation

Projects
None yet
4 participants
Contributor

afrimberger commented Dec 5, 2011

partwin.ccp, partin.h:

  • fixed focus problem
  • disable menubar (we don't want this in a browser plugin...)
  • use own toolbar settings for okularplugin. Changing the toolbar at
    the plugin does no longer change settings for the okular executable!

okularpluginui.rc

  • GUI settings for the okular part
  • predefined toolbar settings suitable for browser plugin

okularplugin_okularui.rc

  • GUI settings for the plugin

CMakeLists.txt

  • install .rc files into right directory ($KDE4_DATA_DIR)

README:

  • Build instructions updated: Seperate build from source

afrimberger added some commits Dec 5, 2011

@afrimberger afrimberger CMakeLists.txt:
  - install .rc files into right directory ($KDE4_DATA_DIR)

README:
  - Build instructions updated: Seperate build from source

partwin.ccp, partin.h:
  - fixed focus problem
  - disable menubar (we don't want this in a browser plugin...)
  - use own toolbar settings for okularplugin. Changing the toolbar at
    the plugin does no longer change settings for the okular executable!

okularpluginui.rc
  - GUI settings for the okular part
  - predefined toolbar settings suitable for browser plugin

okularplugin_okularui.rc
  - GUI settings for the plugin
4b6898a
@afrimberger afrimberger Install instructions updated. ce02205
@afrimberger afrimberger handling of temporary filenames
remove fragments and query parts from temporary filenames before
saving them.
e49ba1f
@afrimberger afrimberger README: Install instructions for Chrome added c087e41
Owner

jeremysanders commented Dec 16, 2011

Sorry for the delay. Haven't had time to check the patch yet.

afrimberger added some commits Jan 16, 2012

@afrimberger afrimberger Changes in the toolbar only affect okularplugin. Fixes #1
Okularplugin now uses its own definition of okular's mainToolbar. So
changes in okularplugin's toolbar do not lead anymore to changes
in okular.
12758c8
@afrimberger afrimberger Added Compiling requirements to README. 9769fb9
@afrimberger afrimberger fixing filename handling of temporary files. 98f6dfd
@afrimberger @afrimberger afrimberger removed debug output c2c999e
@afrimberger @afrimberger afrimberger Some minor improvements 3a37cea
@afrimberger @afrimberger afrimberger Fixed invisible print- and save-dialog. 9b16d7b
@afrimberger afrimberger Removing part from guiFactory.
This fixes the following error message:
okular(15614)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient:
0x7ff74d4d6690 deleted without having been removed from the factory
first. This will leak standalone popupmenus and could lead to crashes.
0a18ecc
@afrimberger afrimberger Improving filename handling.
Unique string is now appended at the end of the filename.
a020ef0
@afrimberger @afrimberger afrimberger Merge branch 'master' of github.com:afrimberger/okularplugin b205bc6
@afrimberger @afrimberger afrimberger define own print button to prevent configuration clash. d5ea187
@afrimberger afrimberger Implemented widget for visualizing download progress. 4d413ec
@afrimberger afrimberger Added more filetypes. Thanks to J.O. Aho. d559b13
@afrimberger afrimberger Save button saves now copy of the document.
Some file types like .xps can't be saved by ocular with the "save_as"
dialog. Saving a copy of the opened document with "save_copy" should work
in all cases.
f5b9fcb
@afrimberger afrimberger Improved filename handling of temporary files. b049800
@afrimberger afrimberger Fixed improper handling of RPATH. Thanks cmake... 431a7a7
@afrimberger afrimberger Optimized download speed estimation. 0e15bca
@afrimberger afrimberger Delete tmp file after window is closed. cf3b7c5

rhuitl referenced this pull request in afrimberger/okularplugin Sep 15, 2012

Closed

Plugin crashes on startup #2

afrimberger and others added some commits Sep 17, 2012

@afrimberger afrimberger Fixed improper resource deallocation of progress widget da61b9f
@afrimberger afrimberger Allow NPP_Write not before widget is created. 6f4cd09
@afrimberger afrimberger Fixing #2: Download can start before widget is created. e8a31f6
@afrimberger afrimberger Fixes #3: Updated plugin pathes of browsers.
Thanks to rhuitl for reporting.
e424b95
@afrimberger afrimberger Fixes #2: Memory corruption in qtbrowserplugin fixed.
Google Chromium (and probably Chrome) frees the NPStream struct after
the NPP_DestroyStream method returns. But QtNPStream uses and accesses
references to NPStream afterwards. This leads to memory corruption and
finally to crashes of plugins.

The bug is not restricted to okularplugin. All other plugins using
qtbrowserplugin are affected by it.
7b72112
@afrimberger afrimberger Fixes #4: Okular hangs when tmp file is deleted too early. f6837b8
@afrimberger afrimberger Added label for displaying errors to progressbar widget.
Also improved error handling a bit. Closing a tab before download
finished does no longer show a message box.
ebd2144
@afrimberger afrimberger Added mouse drag button. 50c02ba
@afrimberger afrimberger Added ebuild for gentoo. d104d97
@afrimberger afrimberger added ebuild for version 1.0.0. 1ab5257
@poletti-marco poletti-marco Update okularplugin-1.0.0.ebuild a7cf148
@poletti-marco poletti-marco Update okularplugin-9999.ebuild df45fdd
@afrimberger afrimberger Merge pull request #5 from poletti-marco/master
Improve the gentoo ebuilds. Thanks to poletti-marco.
8f273da
@poletti-marco poletti-marco Hide statusbar
The statusbar doesn't seem to be used by the okular kpart, remove it. This saves some vertical space, and makes okularplugin another little bit better than kpartsplugin.
Before: http://s13.postimg.org/ne0s0qjjb/before.png
After: http://s13.postimg.org/86pdu4h2f/after.png
8294861
@afrimberger afrimberger Merge pull request #6 from poletti-marco/master
Remove the (apparently useless) statusbar. Thanks to poletti-marco.
30ba90e
@afrimberger afrimberger Added ebuild for version 1.0.1 82ffaca

rubenvb commented Jul 19, 2013

Any chance you can update this? The menu bar really does look kind of silly inside a browser plugin :)

@jeremysanders jeremysanders added a commit that referenced this pull request Jul 22, 2013

@jeremysanders jeremysanders Merge pull request #3 from afrimberger/master
some UI improvements and minor fixes
0aac7ad

@jeremysanders jeremysanders merged commit 0aac7ad into jeremysanders:master Jul 22, 2013

Owner

jeremysanders commented Jul 22, 2013

Thanks - sorry for taking so long. Please take over as an upstream if you feel motivated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment