Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #5 from jeremyw/warnings

Fix Ruby warnings
  • Loading branch information...
commit 2e4b6ca6d8ebadda22355ea5bcad0a299a7bd467 2 parents 3f01c41 + cc7ab1d
@jeremyw authored
View
1  Rakefile
@@ -24,6 +24,7 @@ Rake::TestTask.new(:test) do |test|
test.libs << 'lib' << 'test'
test.pattern = 'test/**/*_test.rb'
test.verbose = true
+ test.warning = true
end
begin
View
2  lib/dribbble/base.rb
@@ -14,7 +14,7 @@ def initialize(attributes=nil)
end
def get(*args, &block)
- self.class.get *args, &block
+ self.class.get(*args, &block)
end
def created_at
View
4 test/player_test.rb
@@ -85,8 +85,8 @@ def test_following
player = Dribbble::Player.find(1)
following = player.following
assert_equal 15, following.size, "default page size"
- following.each do |following|
- assert_kind_of Dribbble::Player, following
+ following.each do |following_player|
+ assert_kind_of Dribbble::Player, following_player
end
following = player.following(:per_page => 2)
View
4 test/shot_test.rb
@@ -28,8 +28,8 @@ def test_find
assert_equal 21603, shot.id
assert_equal 'Moon', shot.title
assert_equal 'http://dribbble.com/shots/21603-Moon', shot.url
- assert_match /http:\/\/dribbble.com\/system\/users\/1\/screenshots\/21603\/shot_1274474082.png\?\d+/, shot.image_url
- assert_match /http:\/\/dribbble.com\/system\/users\/1\/screenshots\/21603\/shot_1274474082_teaser.png\?\d+/, shot.image_teaser_url
+ assert_match(/http:\/\/dribbble.com\/system\/users\/1\/screenshots\/21603\/shot_1274474082.png\?\d+/, shot.image_url)
+ assert_match(/http:\/\/dribbble.com\/system\/users\/1\/screenshots\/21603\/shot_1274474082_teaser.png\?\d+/, shot.image_teaser_url)
assert_equal 400, shot.width
assert_equal 300, shot.height
Please sign in to comment.
Something went wrong with that request. Please try again.