Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the distribution points implementation #4

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Removed the distribution points implementation #4

merged 2 commits into from
Dec 30, 2021

Conversation

vanlooverenkoen
Copy link
Collaborator

No description provided.

Copy link

@ikbendewilliam ikbendewilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could've added a parameter, but commenting it out is fine for me

@NicolaVerbeeck
Copy link

Commenting out is never fine with VCSs

Copy link

@NicolaVerbeeck NicolaVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't comment out code. You could also just return a raw byte representation that end-users can then parse

@vanlooverenkoen
Copy link
Collaborator Author

I will just remove everything. And add an extra todo. Because the raw bytes are not needed for us at the moment. and currently we will not merge upstream

@vanlooverenkoen vanlooverenkoen merged commit 3d5f44d into jeroentrappers:master Dec 30, 2021
@vanlooverenkoen vanlooverenkoen deleted the fix/distribution-points branch December 30, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants