Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update to capybara 2.0 (and mechanize 2.5) #43

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

leifg commented Nov 15, 2012

Update to lateste capybara version

very simple, needed for my project, but I thought I'd share

Collaborator

phillbaker commented Jan 8, 2013

+1 @leifg, did this pass with all specs?

leifg commented Jan 15, 2013

no, but it didn't break any additional tests, so the specs are in the same state as they were before ;-)

I tried fixing the specs but failed badly....

I think someone from the project should bring the specs up to run again, afterwards this PR can be merged.

Owner

jeroenvandijk commented Jan 16, 2013

@leifg I'm affraid none of the maintainers have time for it. I am personally not using this library anymore, because I have stopped working with Ruby apps. I was hoping someone else would take over.

Collaborator

phillbaker commented Jan 16, 2013

@jeroenvandijk would you be interested in another maintainer? I'd be interested in cleaning up some of the pull requests and issues. We're actively using this for a production app and this is blocking for us to upgrade to capy 2.0, so I'd have incentive to keep it working.

Owner

jeroenvandijk commented Jan 18, 2013

@phillbaker Sounds great, I've added you as a collaborator to this project.

Collaborator

phillbaker commented Jan 27, 2013

@leifg I've been playing around with this update, and it looks like a lot of changes are needed. I'm game to start working on this, but would love some help.

For example, see the description in jonleighton/poltergeist#208 for the changes, in this gem a lot of the it_should_behave_like "..." calls blow stuff up with the updated Capy.

With the backward incompatible changes, I think poltergeist's spec of version for capy, "capybara", "~> 2.0", ">= 2.0.1" is better.

Collaborator

phillbaker commented Jan 31, 2013

For reference branch feature/update-capy is work in progress (just updated gemspec, many tests fail).

Collaborator

phillbaker commented Feb 9, 2013

Closed in favor of #44.

@phillbaker phillbaker closed this Feb 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment