Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Upgrade to Capybara 2. Fixes forms and redirects. #44

Merged
merged 6 commits into from Feb 9, 2013

Conversation

Projects
None yet
5 participants
Contributor

ryansch commented Feb 6, 2013

This replaces #37 and #43.

There are quite a lot of changes to bring capybara-mechanize up to capybara 2. The test suite has had an overhaul to become compatible.

The entire capybara 2 session test passes both in rack-test mode (local) and in mechanize mode (remote) with 2 exceptions.

  1. Returning exceptions from the app under test: When we're running against a remote server, we're no longer sending requests directly to the app under test. We want to return errors we received over the wire.
  2. Sending requests to the app under test without a port number: When we're running against a remote server, not specifying the port is the same as hitting port 80. The test doesn't make any sense in this case.

Note that both of those tests pass in the local case.

Contributor

ryansch commented Feb 6, 2013

This should also close #25 and #26.

Contributor

ryansch commented Feb 6, 2013

I just pushed a change that disables the aforementioned two failing tests when running the remote tests. The test suite is now green.

Contributor

ryansch commented Feb 6, 2013

Ruby 1.8.7 doesn't like my use of define_method. I'll get to that in a bit.

Contributor

ryansch commented Feb 6, 2013

Ahh. Capybara 2.0 and up doesn't support 1.8.7. I'm going to drop support in this branch as well.

Contributor

ryansch commented Feb 6, 2013

@phillbaker I think this is ready now.

👍

Contributor

ryansch commented Feb 6, 2013

@phillbaker We're also going to need a version bump when this is accepted to mark a break in compatibility.

Owner

jeroenvandijk commented Feb 6, 2013

@phillbaker I need your (rubygems) email address so I can add you as owner for this gem at rubygems

Collaborator

phillbaker commented Feb 7, 2013

@ryasnsch, thanks a ton for all of your work. This looks very good, let me review and make sure, but it's very promising!

@jeroenvandijk thanks, that'd be helpful. I'm at phillbaker@retrodict.com, on rubygems at http://rubygems.org/profiles/phillbaker.

Owner

jeroenvandijk commented Feb 7, 2013

@phillbaker I've added you as gem owner see http://rubygems.org/profiles/phillbaker . Thanks for getting involved :)

Contributor

aaronchi commented Feb 8, 2013

👍

@phillbaker phillbaker added a commit that referenced this pull request Feb 9, 2013

@phillbaker phillbaker Merge pull request #44 from ryansch/fix-tests-upgrade-deps
Upgrade to Capybara 2. Fixes forms and redirects.
56f6ab7

@phillbaker phillbaker merged commit 56f6ab7 into jeroenvandijk:master Feb 9, 2013

1 check passed

default The Travis build passed
Details
Collaborator

phillbaker commented Feb 9, 2013

Again @ryansch, thanks for the work and involvement. I'll be bumping the version and releasing a preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment