Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Emit events when a marker is found and lost, when using aframe's <a-marker> #303
What kind of change does this PR introduce?
Can it be referenced to an Issue? If so what is the issue # ?
How can we test it?
With my addition,
Does this PR introduce a breaking change?
You can download my forked version
Keep in mind that this pull request has already diverged a lot with the original repository, so by choosing to use my forked version, you won't be getting other improvements or bugfixes for AR.js.
The proper solution would be to get this pull request merged to the main repository. I do not know what its maintainers think about my changes though.
@nikolaymihaylov A really great job! I just tried it and it works really well with
Am I doing something wrong or is just that custom markers are not supported on your branch?
Update: when you apply this commit to your branch it works perfectly :)
I have now excluded the build files from the pull request, which will hopefully make this easier to merge. That means that for anyone using my latest
If anyone has based their applications on this pull request, you can still use the tag
I hope this branch be merged. But while it is not, there is a short solution is:
At your HTML:
Create a method to verify the marker state:
At some point start your verification:
HI @nikolaymihaylov, I will test it myself. I only ask you if you can give me a builded version of your AR.js so I can directly import it on my example and test it. Something like: