spawner doesnt have to be specific #36

Closed
jeromeetienne opened this Issue Jul 26, 2012 · 5 comments

Comments

Projects
None yet
1 participant
@jeromeetienne
Owner

jeromeetienne commented Jul 26, 2012

  • it could be a normal effect
  • may solve the issue of respawning a different kind of particle (super unclear)
@jeromeetienne

This comment has been minimized.

Show comment
Hide comment
@jeromeetienne

jeromeetienne Jul 27, 2012

Owner

Not sure how important this is. Just a remark

Owner

jeromeetienne commented Jul 27, 2012

Not sure how important this is. Just a remark

@jeromeetienne

This comment has been minimized.

Show comment
Hide comment
@jeromeetienne

jeromeetienne Jul 29, 2012

Owner
  • True. But no real harm here
  • only one i see: it may insist one the fact particle can be emitted by any effect. And not only one emittion
  • actually it is rather important
    • example : the exploding firework. One particle go up and after a while it is explode in many smaller ones.
Owner

jeromeetienne commented Jul 29, 2012

  • True. But no real harm here
  • only one i see: it may insist one the fact particle can be emitted by any effect. And not only one emittion
  • actually it is rather important
    • example : the exploding firework. One particle go up and after a while it is explode in many smaller ones.
@jeromeetienne

This comment has been minimized.

Show comment
Hide comment
@jeromeetienne

jeromeetienne Jul 29, 2012

Owner

Super easy change. Do it just for simplicity

Owner

jeromeetienne commented Jul 29, 2012

Super easy change. Do it just for simplicity

@jeromeetienne

This comment has been minimized.

Show comment
Hide comment
@jeromeetienne

jeromeetienne Jul 29, 2012

Owner

notes

  • interestingly, the code is much smaller
  • for steadyRate
    • 68 lines for object version
    • 35 lines for effect version
  • for oneShot
    • 44 lines for object vesion
    • 35 lines for effect version
Owner

jeromeetienne commented Jul 29, 2012

notes

  • interestingly, the code is much smaller
  • for steadyRate
    • 68 lines for object version
    • 35 lines for effect version
  • for oneShot
    • 44 lines for object vesion
    • 35 lines for effect version

jeromeetienne added a commit that referenced this issue Jul 29, 2012

@jeromeetienne

This comment has been minimized.

Show comment
Hide comment
@jeromeetienne

jeromeetienne Jul 29, 2012

Owner

status

  • new code is done
  • old code still there and working. it is for compatbility
  • task: define a policy strategy
Owner

jeromeetienne commented Jul 29, 2012

status

  • new code is done
  • old code still there and working. it is for compatbility
  • task: define a policy strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment