Incorporate 4-module "quiet zone" around codes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to wikipedia, QR codes should incorporate a 4-module "quiet zone", a region of white around all 4 sides of the QR code. This patch implements that as the default. Users can control this behavior by setting the margin option.
Note: if you're wary of changing the default then I'm happy to prepare a different pull request that causes margin to default to 0.
I prepared this patch after reading http://www.die-welt.net/2013/03/opera-standards-and-why-i-should-have-stayed-in-my-cave/ in part because of the apparent opera bug in the rendering of the final row of the table. If this final row is a quiet row then the opera bug would not affect the decodeability of the code.