Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support up to version 40 with (1852 to 4296 characters) + autodection of typeNumber #9

Merged
merged 1 commit into from Sep 29, 2011

Conversation

Projects
None yet
2 participants

kernity commented Sep 27, 2011

Hi,

I just added the feature to autodetect typeNumber from the datasize and push the limit to qrCode version 40 with 1852 to 4296 characters.

Cheers

kernity commented Sep 27, 2011

I can move the code into jquery-qrcode so it'll be independant of qrcode.js...

Owner

jeromeetienne commented Sep 27, 2011

nice one! i will look at it thursday, time is missing now.

if all is working ok, it will be merged.

meanwhile if you could put the code in jquery-qrcode aas you suggested, it would be perfect.

thanks

@jeromeetienne jeromeetienne merged commit af5e6ef into jeromeetienne:master Sep 29, 2011

Owner

jeromeetienne commented Sep 29, 2011

merged. thanks for the contribution

On Tue, Sep 27, 2011 at 5:23 PM, kernity <
reply@reply.github.com>wrote:

Hi,

I just added the feature to autodetect typeNumber from the datasize and
push the limit to qrCode version 40 with 1852 to 4296 characters.

Cheers

You can merge this Pull Request by running:

git pull https://github.com/kernity/jquery-qrcode master

Or you can view, comment on it, or merge it online at:

#9

-- Commit Summary --

  • Add support up to version 40 (1852 to 4296 characters) + autodetect

-- File Changes --

M src/jquery.qrcode.js (5)
M src/qrcode.js (206)

-- Patch Links --

https://github.com/jeromeetienne/jquery-qrcode/pull/9.patch
https://github.com/jeromeetienne/jquery-qrcode/pull/9.diff

Reply to this email directly or view it on GitHub:
#9

Owner

jeromeetienne commented on af5e6ef Sep 29, 2011

thanks for the contribution

@ccoenen ccoenen added a commit to ccoenen/jquery-qrcode that referenced this pull request Jul 30, 2012

@ccoenen ccoenen update to d-project's qrcode.js r327
The original qrcode.js has changed[1] since it has been added to this project. I ported pull request #9 onto it and so far it works fine.

[1]: https://code.google.com/p/d-project/source/browse/trunk/misc/qrcode/js/qrcode.js
20b1fb9

@ccoenen ccoenen added a commit to ccoenen/jquery-qrcode that referenced this pull request Jul 30, 2012

@ccoenen ccoenen update to d-project's qrcode.js r327
The original qrcode.js has changed[1] since it has been added to this project. I ported pull request #9 onto it and so far it works fine.

[1]: https://code.google.com/p/d-project/source/browse/trunk/misc/qrcode/js/qrcode.js
1a03ee1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment