From f2c443e7ca9c36e5bbb38bcb7db0700bceecf4c0 Mon Sep 17 00:00:00 2001
From: Daeyeon Jeong <daeyeon.jeong@samsung.com>
Date: Sun, 8 Apr 2018 18:00:55 +0900
Subject: [PATCH] Fix emitData on readable stream

- emitting 'data' should be handled when calling readable.read.
- assert.equal shouldn't be used inside the module.

IoT.js-DCO-1.0-Signed-off-by: Daeyeon Jeong daeyeon.jeong@samsung.com
---
 src/js/stream_readable.js | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/js/stream_readable.js b/src/js/stream_readable.js
index bdb8eb65f1..eb53461c56 100644
--- a/src/js/stream_readable.js
+++ b/src/js/stream_readable.js
@@ -16,7 +16,6 @@
 
 var Stream = require('stream_internal');
 var util = require('util');
-var assert = require('assert');
 
 
 function ReadableState(options) {
@@ -70,10 +69,6 @@ Readable.prototype.read = function(n) {
     res = null;
   }
 
-  if (state.ended && state.length == 0) {
-    emitEnd(this);
-  }
-
   return res;
 };
 
@@ -106,9 +101,7 @@ Readable.prototype.resume = function() {
   var state = this._readableState;
   if (!state.flowing) {
     state.flowing = true;
-    if (state.length > 0) {
-      emitData(this, readBuffer(this));
-    }
+    this.read();
   }
   return this;
 };
@@ -159,6 +152,7 @@ function readBuffer(stream, n) {
     res = Buffer.concat(state.buffer);
     state.buffer = [];
     state.length = 0;
+    emitData(stream, res);
   } else {
     throw new Error('not implemented');
   }
@@ -183,8 +177,9 @@ function emitEnd(stream) {
 function emitData(stream, data) {
   var state = stream._readableState;
 
-  assert.equal(readBuffer(stream), null);
-  stream.emit('data', data);
+  if (state.buffer.length === 0 || state.length === 0) {
+    stream.emit('data', data);
+  }
 
   if (state.ended && state.length == 0) {
     emitEnd(stream);