Support more debugger protocol in IoT.js #1876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
requested changes
May 14, 2019
Contributor
LaszloLango
left a comment
LaszloLango
left a comment
There was a problem hiding this comment.
Please update the related documentation as well (docs/devs/Use-JerryScript-Debugger.md).
robertsipka
force-pushed
the
debugger_packets
branch
3 times, most recently
from
830a361 to
a98ee7b
Compare
Contributor
Author
|
@LaszloLango : Thanks for the review, I've updated it accordingly. |
daeyeon
reviewed
May 21, 2019
|
|
||
| #### Select transport and protocol layers | ||
|
|
||
| There are two available extension-provided transport layers, websocket and rawpacket, and two procotol layers, tcp and serial. Each initializes the debugger and blocks until a client connects. If you want to specify the debugger transmission layer (default: websocket) or transmission protocol (default: tcp) over the communication you can do with the `--debug-channel [websocket|rawpacket]` and `--debug-protocol [tcp|serial]` options: |
Member
There was a problem hiding this comment.
The title is a bit confusing. There are many terms here. (transport layer, protocol layer, transmission layer, and transmission protocol.) How about using only channel and protocol?
e.g) Select transport and protocol layers - > Select Channel and Protocol
robertsipka
force-pushed
the
debugger_packets
branch
from
a98ee7b to
36fbb5f
Compare
Contributor
Author
|
@daeyeon : You're right, thanks. I've changed it. |
daeyeon
reviewed
May 22, 2019
|
|
||
| #### Select channel and Protocol | ||
|
|
||
| There are two available extension-provided channel, websocket and rawpacket, and two procotol, tcp and serial. Each initializes the debugger and blocks until a client connects. If you want to specify the debugger channel (default: websocket) or protocol (default: tcp) over the communication you can do with the `--debug-channel [websocket|rawpacket]` and `--debug-protocol [tcp|serial]` options: |
Member
There was a problem hiding this comment.
I found a typo: procotol -> protocol. Please also check the plural form for channel and protocol.
Adding new options to select serial protocol and rawpacket communcation channel. IoT.js-DCO-1.0-Signed-off-by: Robert Sipka rsipka.uszeged@partner.samsung.com
robertsipka
force-pushed
the
debugger_packets
branch
from
36fbb5f to
0a8f2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new options to select serial protocol and rawpacket communcation channel.