From 85b291af51c803539bd97dd93cdf6c829161a846 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Tue, 4 Jan 2022 13:10:20 +0100 Subject: [PATCH] Const literal marker should be processed before group assignment marker This patch fixes #4925. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik robert.fancsik@h-lab.eu --- jerry-core/parser/js/js-parser-expr.c | 8 +++---- .../es.next/regression-test-issue-4925.js | 21 +++++++++++++++++++ 2 files changed, 25 insertions(+), 4 deletions(-) create mode 100644 tests/jerry/es.next/regression-test-issue-4925.js diff --git a/jerry-core/parser/js/js-parser-expr.c b/jerry-core/parser/js/js-parser-expr.c index 03309c128d..72edd42e00 100644 --- a/jerry-core/parser/js/js-parser-expr.c +++ b/jerry-core/parser/js/js-parser-expr.c @@ -3420,16 +3420,16 @@ parser_process_binary_assignment_token (parser_context_t *context_p, /**< contex #if JERRY_ESNEXT bool group_expr_assingment = false; - if (JERRY_UNLIKELY (context_p->stack_top_uint8 == LEXER_ASSIGN_GROUP_EXPR)) + if (JERRY_UNLIKELY (context_p->stack_top_uint8 == LEXER_ASSIGN_CONST)) { - group_expr_assingment = true; parser_stack_pop_uint8 (context_p); + parser_emit_cbc_ext (context_p, CBC_EXT_THROW_ASSIGN_CONST_ERROR); } - if (JERRY_UNLIKELY (context_p->stack_top_uint8 == LEXER_ASSIGN_CONST)) + if (JERRY_UNLIKELY (context_p->stack_top_uint8 == LEXER_ASSIGN_GROUP_EXPR)) { + group_expr_assingment = true; parser_stack_pop_uint8 (context_p); - parser_emit_cbc_ext (context_p, CBC_EXT_THROW_ASSIGN_CONST_ERROR); } #endif /* JERRY_ESNEXT */ diff --git a/tests/jerry/es.next/regression-test-issue-4925.js b/tests/jerry/es.next/regression-test-issue-4925.js new file mode 100644 index 0000000000..c071711209 --- /dev/null +++ b/tests/jerry/es.next/regression-test-issue-4925.js @@ -0,0 +1,21 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +try { + for (const i= 0; ;) + (i) = 5; + assert(false); +} catch (e) { + assert(e instanceof TypeError); +}