Initial RAM optimization for ESP8266 #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
enhancement
| #ifdef CONFIG_STORE_CONST_IN_ROM | ||
| #ifndef ICACHE_RODATA_ATTR | ||
| #define ICACHE_RODATA_ATTR __attribute__((section(".irom.text"))) | ||
| #endif |
There was a problem hiding this comment.
#endif /* !ICACHE_RODATA_ATTR */
slaff
force-pushed
the
feature/memory-optimization
branch
2 times, most recently
from
350a0dd
to
5ab9da0
Compare
|
LGTM |
| @@ -166,6 +166,15 @@ | |||
| #endif /* CONFIG_ECMA_COMPACT_PROFILE */ | |||
|
|
|||
| /** | |||
| * Normally your compiler stores const(ant)s in ROM. Thus saving RAM. | |||
slaff
force-pushed
the
feature/memory-optimization
branch
2 times, most recently
from
21a0dcd
to
a3b215d
Compare
| ifneq ($(MFORCE32),) | ||
| # If your compiler supports the -mforce-l32 flag then | ||
| # uncomment the lines below to gain additional Kb free RAM | ||
| ESP_CFLAGS += -DCONFIG_STORE_CONST_IN_ROM |
There was a problem hiding this comment.
The define could be added here :)
slaff
force-pushed
the
feature/memory-optimization
branch
from
a3b215d
to
1430be7
Compare
|
@zherczeg I added the recommended changes. |
| ifneq ($(MFORCE32),) | ||
| # Your compiler supports the -mforce-l32 flag then | ||
| # contants can be placed in ROM to free additional RAM | ||
| ESP_CFLAGS += -DJERRY_CONST_DATA="__attribute__((aligned(4))) __attribute__((section(".irom.text")))" |
There was a problem hiding this comment.
I'm not an expert of GNU make, but the double quote usage is a bit odd to me here. Are you sure this will work as expected? Shouldn't be escaped the quotes around .irom.text?
|
I like this patch much better. LGTM after Laszlo's comments are fixed. |
slaff
force-pushed
the
feature/memory-optimization
branch
from
1430be7
to
82bba0d
Compare
by putting big constants into ROM, instead of residing in RAM. Related to jerryscript-project#1224. JerryScript-DCO-1.0-Signed-off-by: Slavey Karadzhov slaff@attachix.com
slaff
force-pushed
the
feature/memory-optimization
branch
from
82bba0d
to
ce8abfb
Compare
|
Still LGTM |
|
@slaff, thanks for the fixes. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by putting big constants into ROM, instead of residing in RAM.
Related to #1224.
JerryScript-DCO-1.0-Signed-off-by: Slavey Karadzhov slaff@attachix.com