Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Thumb instructions on TizenRT. #2629

Merged

Conversation

rtakacs
Copy link
Contributor

@rtakacs rtakacs commented Nov 30, 2018

In order to decrease the binary size of JerryScript, enabled the Thumb instruction set that is supported on ARM Cortex-R series processors.

The following table shows the binary size reduction by this patch:

commit: 8410570 (2018-11-28) this patch
text 199708 B 130440 B
bss 74088 B 74088 B
data 0 B 0 B
rodata 12341 B 12342 B

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmake/toolchain_mcu_artik053.cmake Outdated Show resolved Hide resolved
In order to decrease the binary size of JerryScript, enabled the Thumb
instruction set that is supported on ARM Cortex-R series processors.

JerryScript-DCO-1.0-Signed-off-by: Roland Takacs rtakacs.uszeged@partner.samsung.com
@rtakacs
Copy link
Contributor Author

rtakacs commented Nov 30, 2018

@LaszloLango Thanks! I've updated the PR.

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, LGTM

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosthekiss akosthekiss merged commit 3f9dd0f into jerryscript-project:master Dec 2, 2018
@rtakacs rtakacs deleted the artik053-thumb-instructions branch January 18, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants