Correct release of spread arguments #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the `opfunc_spread_arguments` argument release process the stack pointer was incremented early resulting in a state where one of the arguments was not freed causing a memory leak. JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.usz@partner.samsung.com
galpeter
added
bug
rzr
added a commit
to TizenTeam/iotjs
that referenced
this pull request
Oct 15, 2020
Forwarded: https://github.com/jerryscript-project/iotjs/pulls/rzr Relate-to: jerryscript-project/jerryscript#3867 Change-Id: I54dde024b25098387b33b7c1150df544c40fb36b IoT.js-DCO-1.0-Signed-off-by: Philippe Coval <rzr@users.sf.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
opfunc_spread_argumentsargument release processthe stack pointer was incremented early resulting in a state where
one of the arguments was not freed causing a memory leak.
Fixes: #3860
Fixes: #3859
Fixes: #3858