-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin exotel dependency to 0.1.5 due to security issue in 0.1.6 #931
Conversation
|
Thanks for submitting this. I reviewed 0.1.6 and I do see the requests to two Russian-owned domains, with Windows-hosts being the infection target. Are you aware of any known CVE for this? |
|
Not as of now. Cross linking report to maintainer repo - sarathsp06/exotel-py#10 |
|
I've sent a request to PyPI to have the Exotel 0.1.6 removed. Thanks again for raising this so quickly. |
|
We've also notified PyPi about the issue |
|
@jertel Since the dependency is unmaintained and only contains about 5 post request functions, maybe it's worth dropping the dependency entirely and implementing support directly inside elastalert itself? |
|
Implementing the Exotel integration directly into ElastAlert2 exotel.py file is fine with me, if you are up to submitting the PR. Optional dependencies would reduce risk but will still cause code scanners to trigger, simply by having the python code exist, even if the main codebase didn't include that module. So to avoid the code scanners from triggering you'd have to dynamically pull down the alerters from the Internet. I'm not opposed to the idea but it would be a significant change. |
|
Version |
|
Description
Version
0.1.6ofexotelpackage was released 2 hours ago (with the last release0.1.5happening in 2017).Version
0.1.6has malicious code insetup.py. Lock version of the package to last known good,0.1.5as a hotfix.Ref https://pypi.org/project/exotel/0.1.6/#history
Checklist
make test-dockerwith my changes.Questions or Comments