Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROF code. #8

Merged
merged 1 commit into from Jul 7, 2013
Merged

Fix ROF code. #8

merged 1 commit into from Jul 7, 2013

Conversation

nico
Copy link
Contributor

@nico nico commented Jun 20, 2013

The Chambolle paper this is based on --
http://www.cmap.polytechnique.fr/preprint/repository/578.pdf --
initializes Xi_0 with 0, not with g (see page 13 at the bottom).

Consider this code:

im = misc.lena()
U, T = rof.denoise(im, im, tv_weight=30)
imshow(U)

Before this change, this produced the output
http://i.imgur.com/u68Vakj.jpg . With this change, it produces
http://i.imgur.com/3eHli7J.jpg which looks more correct.

The Chambolle paper this is based on --
http://www.cmap.polytechnique.fr/preprint/repository/578.pdf --
initializes Xi_0 with 0, not with g (see page 13 at the bottom).

Consider this code:

    im = misc.lena()
    U, T = rof.denoise(im, im, tv_weight=30)
    imshow(U)

Before this change, this produced the output
http://i.imgur.com/u68Vakj.jpg . With this change, it produces
http://i.imgur.com/3eHli7J.jpg which looks more correct.
@jesolem
Copy link
Owner

jesolem commented Jul 5, 2013

Great catch. I will take the change for the file in PCV/tools but not the book copy folder (that might confuse some readers). Thanks!

@jesolem
Copy link
Owner

jesolem commented Jul 5, 2013

Thanks for this!

I will take the change for the file in PCV/tools but prefer to leave the
book copy folder unchanged until a second edition.

I'd like to give you credit so if you change the pull request to just the
one file, I'll accept it.

@nico
Copy link
Contributor Author

nico commented Jul 5, 2013

Do you want me to completely revert the change to the book copy, or should I add some kind of comment ("# This is what's printed in the book, but see PCV/tools for an improved version" or something)?

@jesolem
Copy link
Owner

jesolem commented Jul 7, 2013

On second thought, I'll take it as is and for now add a comment that the two lines were changed from what's in the book.

@jesolem jesolem closed this Jul 7, 2013
@jesolem jesolem reopened this Jul 7, 2013
jesolem added a commit that referenced this pull request Jul 7, 2013
@jesolem jesolem merged commit bc1d91a into jesolem:master Jul 7, 2013
@nico
Copy link
Contributor Author

nico commented Jul 7, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants