Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tutorial for custom indicator #12

Merged
merged 4 commits into from Jun 14, 2020

Conversation

fengkiej
Copy link

No description provided.

@cryptocoinserver
Copy link
Collaborator

Very nice good job. Very detailed. Maybe we should change the structure a little and put the directory with the custom indicators directly in the project or under strategies. That way you don't have to add it to each strategy again: Like this approach: https://forum.jesse-ai.com/d/41-helper-class-sharable-for-all-strategies/6 With multiple dots to go a directory up like: import ..custom_indicators as cta - didn't test it. Might be different.

Also what could lead to confusion is the source_type part. Its working your way because you use the jesse indicators, but for the tutorial it might be better to include the function and use the ema directly from talib. Or we use the direct way: candles[:, 2] - As get_candles_source is just a helper.

source = get_candle_source(candles, source_type=source_type)
and then
talib.EMA(source, timeperiod=period)

@cryptocoinserver
Copy link
Collaborator

I can add some more tips to the tutorial after this PR is merged. I wrote / converted most of the indicators and faced some issues here and there. Like working with tulipy needs some additional care. Some helpful numpy stuff i found out and how to do loops, if a indicators needs them.

@fengkiej
Copy link
Author

Hi @firesurf, thanks for the feedback! Will update ASAP per your suggestion 👍

@cryptocoinserver cryptocoinserver merged commit 79d4403 into jesse-ai:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants